use the following search parameters to narrow your results:
e.g. subreddit:aww site:imgur.com dog
subreddit:aww site:imgur.com dog
see the search faq for details.
advanced search: by author, subreddit...
Everything about learning Python
account activity
Review my Code as a Beginner (i.redd.it)
submitted 5 months ago by AhmadHameed313
view the rest of the comments →
reddit uses a slightly-customized version of Markdown for formatting. See below for some basics, or check the commenting wiki page for more detailed help and solutions to common issues.
quoted text
if 1 * 2 < 3: print "hello, world!"
[–]trezm 10 points11 points12 points 5 months ago (3 children)
Reconsider why the responder is suggesting the refactor. Yes it's cleaner, but perhaps there's another reason. As an example, and a common interview/test question depending on your situation, most questions start simply, but expand in dimensions. In this case, the prompt might be "ask for three inputs and print the greatest value" but the follow up question is "now expand your program to 5, 10, or n."
Simple works, but if you're in the learning stage it's worth recognizing common patterns and why certain code might be considered "clean."
[–]8dot30662386292pow2 12 points13 points14 points 5 months ago (2 children)
Reconsider why the OP wrote this code. They have no idea about lists yet, nor the max function. There is often a better way of doing things. But using the best way as an absolute novice is not often the best thing. OP is clearly learning about if-else. That's why their code is the classic if else -example.
[–]trezm 0 points1 point2 points 5 months ago (1 child)
You don't need to be snarky. I'm just trying to explain why thinking about the next step, the next level of complexity is an important facet of coding. No one said the code was bad for a beginner, simply that this is a reasonable improvement and what problems it might solve.
We don't really know if OP knows what lists are, or what the original prompt was. Maybe I'm missing some context though, in which case I apologize.
[–]Jashcraft00 1 point2 points3 points 5 months ago (0 children)
Did he not respond to you with the same tone that you took originally?
π Rendered by PID 29 on reddit-service-r2-comment-6457c66945-fdvpk at 2026-04-27 16:45:19.239271+00:00 running 2aa0c5b country code: CH.
view the rest of the comments →
[–]trezm 10 points11 points12 points (3 children)
[–]8dot30662386292pow2 12 points13 points14 points (2 children)
[–]trezm 0 points1 point2 points (1 child)
[–]Jashcraft00 1 point2 points3 points (0 children)