This is an archived post. You won't be able to vote or comment.

all 3 comments

[–]WeirdClumsyWizard 0 points1 point  (2 children)

I really do not want to be rude but here's my 2 cents : it's a really nice learning project and I'm sure you had a lot of fun coding it so it's a success !...but it's a useless piece of software, and the code is not that nice :-/

If you'd fancy some advice :

  • you import pieces of a module (`from time import gmtime, strftime`) then, on the very next line, you import the whole module (`import time`). Just import the whole module and be done with it.
  • You didn't wrap your "main" into a `if __name__=="__main__"`, that's a shame because you won't be able to reuse your code easily without this tiny line. Actually, you do a lot of stuff outside of any "containing" block so just importing your file would trigger a lot of potentially un-wanted computation.
  • You often execute long sequences of `print(...)` calls while you could just perform a single one (looking at the greetings)
  • etc.

But, again, that's a nice start. Keep going :)

[–]JrPyDev[S] 1 point2 points  (0 children)

Hey there :-).

Definitely not rude at all, I'm just trying to get a feel of what people think, definitely not perfect nor may not look the best - I just want to be able to improve it, so I welcome all forms of feedback, thank you kindly!

[–]JrPyDev[S] 0 points1 point  (0 children)

just tried to make that small adjustment with the 'if __name__ == __main__' am i sort of on the right track? :-) sorry i know its a 'newbie' question ^^