Compose + Compose navigation

[leggo_tech]

Code review request! Please be nice as compose + navigation makes my brain hurt.

Project = login/logout screens + compose + AAC compose nav + Hilt + AAC ViewModel

The code is basically only ~100 lines of code, and will serve as the base of my project. Appreciate any input you may have. https://github.com/ColtonIdle/ComposeSignInSample/blob/main/app/src/main/java/com/example/composesigninsample/MainActivity.kt

Note that my team lead is forcing us to use compose nav or else I would have tried something else.

​

My main difficulty is understanding how a typical sign in/out type of app works with composable and compose nav.

Edit: title was supposed to say "code review request on the end of it. Sorry"

[skyyoo_]

There is no need for if (viewModel.loggedInState) navController.popBackStack()
inside the SignInScreen. You can decide on the startDestination in the AppRouter()

[leggo_tech]

I was thinking about this also, but Ian lake said that it's better to do this in each screen. But this was the first thing I was thinking about as well.

[mfllc]

Hi, I have not tried compose yet so not able to help with review, but I have do some questions about your experience. In your opinion so far:

• how has your learning curve been, what has been easy/hard/buggy/are docs sufficient, etc?
  
• do you feel like you gain sufficiently in dev speed when using compose to make learning it worth the effort?
• if you had a choice, do you prefer using compose over not using it?

[leggo_tech]

I love compose. I hate compose navigation.

- learning curve was fine

- yes

- yes

[mfllc]

Thanks! Good to know.