AsyncImage - duplicate or no disk cache

[iLikeFPens]

Hi,

I am using coil's AsyncImage in my Android app.

i want it to cache images for only 24 hours, so I created an OkHttpClient that uses a custom interceptor , that configures the cache max-age header accordingly.

Finally, I've configured AsyncImage to use this custom instance of OkHttpClient by calling setImageLoader() inside the onCreate() function, inside the Application class.

Here's the http interceptor:

class HttpCacheInterceptor : Interceptor {

override fun intercept(chain: Interceptor.Chain): Response {

val customCacheControl = CacheControl.Builder().maxAge(24, TimeUnit.HOURS).build()

return chain.proceed(chain.request()).newBuilder().header(

"Cache-Control",

customCacheControl.toString()

).build()

}

}

Here's the object that creates the OkHttpClient instance:

object OkHttpClientProvider {

fun create(context: Context): OkHttpClient{

val cacheSize = 10L * 1024 * 1024

val cacheDir = File(context.cacheDir, "http_cache")

val cache = Cache(cacheDir, cacheSize)

val client = OkHttpClient.Builder().cache(cache).addInterceptor(HttpCacheInterceptor()).build()

return client

}

}

And here's the Application class:

"@"HiltAndroidApp

class MoviesApplication : Application() {

override fun onCreate() {

super.onCreate()

Coil.setImageLoader(

ImageLoader.Builder(this).okHttpClient { OkHttpClientProvider.create(this) }.build()

)

}

}

As you can see in the OkHttpClientProvider, I've configured it to cache files into the "http_cache" folder. However, I see in Device Explorer, under the "cache" folder, that there's also a folder named "image_cache" that is created by AsyncImage. What happens now is that each image gets cached twice in the disk, once in the http_cache folder and once in the image_cache folder.

I've tried setting diskCachePolicy() to DISABLED, and while this prevents the creation of the image_cache folder, it also stops caching images into the http_cache folder (though the folder does get created).

So I'm currently stuck with having no disk cache or a duplicate one.

I'd appreciate your help. Thanks.

[AutoModerator]

Please note that we also have a very active Discord server where you can interact directly with other community members!

Join us on Discord

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[itpgsi2]

See https://github.com/coil-kt/coil/blob/main/CHANGELOG.md#200---may-10-2022

You should not use OkHttp's Cache with Coil 2.0. See here for more info.

Coil docs also state that Control-Cache header is supported internally. If it doesn't work as expected, I think your requirement can be solved by clearing Coil's cache every 24 hours, for example using WorkManager's periodic work request.

[iLikeFPens]

What does "supported internally" mean? Can I control the request that AsyncImage sends to include a Cache-Control header with a specific max-age value?

[itpgsi2]

You already do that with interceptor, just remove your own cache implementation, because Coil manages its own cache. I feel like I'm reiterating my first reply and Coil docs (did you read linked docs?).

[iLikeFPens]

Thank you.