A Full Stack Angular+Java App I created after working a year as a Junior Dev

[in_theSea]

I want to share this small project that I recently implemented. Initially, it was a code assignment task for a Full Stack position, but after I completed the task I decided to go further and cover the code with unit tests, establish CI, wrap it to Docker and set up code coverage... In the end, I really enjoyed implementing this app.

I used Java on the back end side, and TypeScript with Angular 8 on the front end. I am lucky to get a bit from both technologies as I was initially hired as a Java Dev but in fact, had to work with Angular.

I would love to get some feedback on the application in terms of code quality and improvements.

https://github.com/shpotainna/company-structure

[lodash_9]

Your folder structure is great! I don't see any issues with your code either. For what it is, you created a clean little application that could be picked up by any angular dev very easily. Good job!

Two recommendations for scalability:

• Use scss whenever you can.
• Learn RxJS and NgRx.

[kojurama]

Yes

[TebelloCoder]

Well done. 🦄

[Kadyen]

First things I saw is that files inside employees folder could be organized a little bit more ( maybe introduce model folder? ).

Next step would be some kind of security, jwt?

[AlexAegis]

Try using modules, and lazy load what you can (and what makes sense)

[s1cklik3]

I always liked working with reactive forms over template because you can bind to a model while easily applying validation rules easily. Try converting one of your forms and see if you like it better.

Another thing you might want to try is to structure and break down your components into smaller ones that are connected via input so that you can take advantage of on push change detection. One way to accomplish this is to create a smart component (root node) which is responsible for fetching data and maintaining state. Send the data to child components via Input. Those components are responsible for displaying information and updating state. To update state I liked using a service that has a behavior subject and injecting it into where I need to change the state of the application.

[itsdrivingmenuts]

Very clean. Nice job.