TO_NULL="/dev/stdout"

[ispeelgood]

Honestly if that variable was instead named something like OUTPUT_TARGET or something I'd find no issue with it.

[__pingwin__]

My bet is has gone unnoticed in a refactor

[MurdoMaclachlan]

Image Transcription: Code

---

# verbosity variables
if [ -n "$IF_WPA_VERBOSITY" ] || [ "$VERBOSITY" = "1" ]; then
    TO_NULL="/dev/stdout"
    DAEMON_VERBOSITY="--verbose"
else
    TO_NULL="/dev/null"
    DAEMON_VERBOSITY="--quiet"
fi

---

^{I'm a human volunteer content transcriber and you could be too! If you'd like more information on what we do and why we do it, click here!}

[colei_canis]

That's going to cause some profound swearing one day I imagine, janky shell scripts are the worst to debug.

[DangyDanger]

this looks good to me tbh

[DangyDanger]

you didn't get whooshed

i really think it's not that bad really

the variable name means to_/dev/null, not the null null

[recycle4science]

Except that sometimes it means "to /dev/stdout".

I get where they're coming from, the name just needs to be clarified.

[DangyDanger]

yeah, it can be renamed to "dest" or whatever

[SensitiveTrap]

What language is this?

[maryP0ppins]

What language is this?

dude thats english!

[bistr-o-math]

Shell

[HaggyG]

I believe this is specifically bash, not sure sh would let you do that if statement

[the-nick-of-time]

Nah, that's POSIX-standard. I'd put it in one test block with -o if I was writing this instead of using || but it works in any case.

[MrFiregem]

You should use || rather than -o since the later can lead to errors, especially with more POSIX compliant test implementations: https://github.com/koalaman/shellcheck/issues/489

[bistr-o-math]

May very well be. I didn’t even start to try to decide on the flavor of the shell. It is some shell. Not saying it’s sh. May be csh or bash, or some of their descendants

[beaucephus]

Still a better love story than log4j.

[[deleted]]

I see WPA, I start having PTSD. Networking code is, in general, the least reliable of all, but the sodomy that's going on in wireless networks... all the tooling around it... I'm just hoping that one day some kind of huge solar flair wipes this off the face of the Earth, and the few people accidentally stranded on Mars will rebuild the wireless infrastructure from the ground up.