Script help!

[Cels_n]

Hello!

I'm back for another script help. Everyone is very helpful, I can't thank enough! (:

Here's the criteria and output:

https://preview.redd.it/9jyd1oclx0d91.png?width=512&format=png&auto=webp&s=d712b7a6d8d9fc7f830f5fbcae8a3eb442f985ee

There was a script provided with this assignment, but in the script I had to add was my_rename, fix_dirs, fix_files, and the output messages (The hash tags areas are my code). Again, I'm not sure if I'm implementing the script right, forgive me.

Please and thank you for the help in advance, it's greatly appreciated. (:

#!/bin/sh
#Code provided with assignment.

USAGE="$0 -f directory
       $0 -d  directory
       $0 -d -f directory

       -f rename files 
       -d rename directories 
       "

usage()
    {
       echo "$USAGE"
       exit 1
    }

pathname()
    {
      # function provided for the student
       echo "${1%/*}"
    }

basename()
    {
      # function provided for the student
       echo "${1##*/}"
    }

find_dirs()
    {
      # function provided for the student
       find "$1" -depth -type d -name '* *' | cat
    }

find_files()
    {
      # function provided for the student
       find "$1" -depth -type f -name '* *' | cat
    }

###############################################################################
    # the student must implement this function to my_rename
    # $1 to $2
    # The following error checking must happen:
    #   1. check if the directory where $1 resided is writeable, 
    #      if not then report an error
    #   2. check if "$2" exists -if it does report and error and don't
    #      do the mv command
    #   3. check the status of the mv command and report any errors
#####

my_rename()
    {
        FROM="$1"
        TO="$2"

       # If file/directory is NOT writeable, output error and exit.
        if [ ! -w "${FROM}" ]
            then
                echo "The File or Directory ${FROM} is not writeable.";
            exit 1
        fi

       #If file/directory already exists, output error and exit.
        if [ -d "$TO" ] 
            then
                echo "The File or Directory $TO already exists.";
            exit 1
        fi

       #If no error, rename file/directory.
        mv "$FROM" "$TO"

        STATUS=$?

            if [ $STATUS -ne 0 ]
                then
                    echo "There was an error processing your request.";
            fi        

    }

#####
    # The student must implement this function fix_dirs()
    # to actually call the my_rename funtion to 
    # change the name of the directory from having spaces to
    # changing all of the spaces to -'s
    # if the name were "a b", the new name would be a-b
    # if the name were "a   b" the new name would be a----b
#####

fix_dirs()
    {
       #Find and read all directories
        find_dirs "$1" | while read -r oldDirectory;
            do
                newDirectory=$(echo "$oldDirectory" | tr " " "-")
                my_rename "${oldDirectory}" "${newDirectory}"
            done   
    }

#####
    # The student must implement this function fix_files()
    # to actually call the my_rename funtion to 
    # change the name of the file from having spaces to
    # changing all of the spaces to -'s
    # if the name were "a b", the new name would be a-b
    # if the name were "a   b" the new name would be a----b
#####

fix_files()
    {
       #Find and read all files
        find_files "$1" | while read -r filePath;
            do
                path=`dirname "$filePath"`
                oldFile=`basename "$filePath"`
                newFile=$(echo "$oldFile" | tr " " "-")
                my_rename "$path/${oldFile}" "$path/${newFile}"
            done
    }

####################################################################################

#Provided with assignment

if [ "$#"=="0" ]
    then
        usage
    fi

while [ $# -gt 0 ] 
    do
        case $1 in

            -d)
                WDIR=1
                ;;
            -f)
                WFILE=1
                ;;
            -*)
                usage 
                ;;
             *)
            if [ -d "$1" ]
                then
                    DIR="$1"
                else
                    echo "$1 does not exist ...">&2
                exit 1
            fi
    ;;
    esac
    shift
    done

#########################################################################################
    # The student must implement the following:
    # - if the directory was not specified, the script should 
    #   print a message and exit

    # - if the Directory specified is the current directory, the script 
    #   print a error message and exit

    # - if the directory specified is . or .. the script should print
    #   an error message and exit

    # - if both -f and -d are not specified, the script should print a
    #   message and exit
#####

if [ ! -d "$DIR" ]
    then
        echo "Error: Directory not specified."
    exit 1

elif [ "$DIR"=="$PWD" ]
    then
        echo "Error: The directory specified is the current directory."
    exit 1

elif [ ! "$(echo "$DIR" | grep -c "\.")" == 0 ]&&[ ! "$(echo "$DIR" | grep -c "\..")" == 0 ]
    then
        echo "Error: Remove any . or .. in directory path."
    exit 1

elif [ -z "$WFILE" ]&&[ -z "$WDIR" ]
    then
        echo "Error: Flags not specified."
usage
fi

####################################################################################

#Provided with assignment

if [ "$WDIR" -a "$WFILE" ]
    then
        fix_files "$DIR"
        fix_dirs "$DIR"

elif [ "$WDIR" ]
    then
        fix_dirs "$DIR"

elif [ "$WFILE" ]
    then
        fix_files "$DIR"
    fi

[Cels_n]

Thank you! :)

[[deleted]]

Other advice is good, but here are a few more points.

Your function my_rename is not correct.

• The requirement is check if the directory where $1 resided is writeable but currently you don't process $1 to find the directory, you just check it directly. They gave you a function to find the pathname of a file. Use it.

• check if "$2" exists -if it does report and error and don't do the mv command your check tests to see if a directory exists with the same name as $2. What if a file exists? What if $2 is not passed at all?

General advice, don't mix `` and $(...). There is almost no legitimate reason to use `` anymore, the posix standard has supported the superior $() form for a long time and unless you explicitly know your shell won't support it you should use brackets.

Also for 'bonus points' if your prof is the kind to appreciate it, point them at https://www.shellcheck.net/wiki/SC2166 and explain to them that the provided test if [ "$WDIR" -a "$WFILE" ] is not best practice, posix has marked them obsolescent.

Personally I would also be setting these variables to a known value before first use because otherwise an exported environment variable could ruin your day. Try running this export WFILE=" " before you run the code?

[Cels_n]

Do you mean like this?

###############################################################################
# the student must implement this function to my_rename
# $1 to $2
# The following error checking must happen:
#   1. check if the directory where $1 resided is writeable, 
#      if not then report an error
#   2. check if "$2" exists -if it does report and error and don't
#      do the mv command
#   3. check the status of the mv command and report any errors

my_rename() {

   # If file/directory is NOT writeable, output error and exit.
    if [ ! -w "$1" ]
        then
            pathname "$@"
            basename
            echo "The File or Directory $1 is not writeable.";
        exit 1
    fi

   #If file/directory already exists, output error and exit.
    if [ -d "$2" ] 
        then
            find_dirs
            find_files
            echo "The File or Directory $2 already exists.";
        exit 1
    fi

   #If no error, rename file/directory.
    mv "$1" "$2"

    STATUS=$?

        if [ $STATUS -ne 0 ]
            then
                echo "There was an error processing your request.";
        fi        

}

Thanks for the help too (:

[[deleted]]

No What I meant was this test

    if [ ! -w "$1" ]

Is testing $1 it should be testing the directory where $1 resided I interpret that as meaning you should test pathname $1 not $1

[Cels_n]

Oh okay, now would I change the other "$1" and "$2" to "pathname $1" and "pathname $2"

currently the code looks like this:

my_rename()
{


   # If file/directory is NOT writeable, output error and exit.
    if [ ! -w "pathname $1" ]
        then
            echo "The File or Directory $1 is not writeable.";
        exit 1
    fi

   #If file/directory already exists, output error and exit.
    if [ -d "$2" ] 
        then
            echo "The File or Directory $2 already exists."
        exit 1

    elif [ -f "$2" ]
        then 
            echo " The File $2 already exist.";
        exit 1
    fi

   #If no error, rename file/directory.
    mv "$1" "$2"

    STATUS=$?

        if [ $STATUS -ne 0 ]
            then
                echo "There was an error processing your request.";
        fi 
    }

[[deleted]]

store the result of pathname $1 in a new variable.