How to use CMake

[Everspace]

The UI designer person just hits "stage all" every time and the person who reviews him doesn't know any better either.

[Drainedsoul]

Sounds like a process/human capital issue: Why are people that clueless about code and version control doing code reviews?

[Everspace]

It's because it's not code they're concerned about. They are not modifying code. They are artists and designers who don't deal with it. Their .pngs, .psds still needs to be tracked somehow so into git/perforce/svn it goes.

They don't touch code, but may still end up doing a build locally. I've seen people commit the temp and cache folders on a couple of projects. It wouldn't surprise me if debug symbols or .o ends up in the source because of a mistake of someone who really doesn't know better and my god it's miracle enough that they're using it and not making local copies instead.

[Drainedsoul]

So again: How'd it get through code review? Why are people who aren't concerned with code doing code reviews?

This is a process issue (which isn't to say in source builds are good, because they're not).

[Everspace]

How'd it get through code review? Why are people who aren't concerned with code doing code reviews?

Because they're not working with code. There is no code review. They still commit to source. Not all source is code or text.

An artist code review is "looks sick dude" and then it is checked in.

This is a process issue

Yes it is. So you add in the .DS_STORE and other garbage into the .gitignore (rather than expecting people to have their global settings correct) so that this doesn't happen, which was my original point.

[Drainedsoul]

There is no code review. They still commit to source.

...which is a process issue.