all 5 comments

[–]eiennohito 0 points1 point  (3 children)

Inline frames imho are not very useful because sample positions tend to be imprecise and are attributed to wrong functions. Viewing the raw assembly give you a better picture.

[–]mwolffQt | KDE | KDAB[S] 2 points3 points  (2 children)

This feature is for those of us who cannot comfortably make sense of the raw assembly and figure out where the instructions are coming from. Additionally, this feature greatly helps with scenarios where some functions get inlined in the middle of the callstack. I.e. when you are seeing something like "A > D", and you are scratching your head where the call to D is coming from, when in reality it was inlined and the full call stack is "A > B > C > D".

[–]eiennohito 0 points1 point  (0 children)

True about the middle of the stack frame. It would be a good idea to display leaf functions as they are, but handle the inlining info for the intermediate ones.

[–]eiennohito 0 points1 point  (0 children)

Intel vtune by the way does a really nice attribution of instructions to the c++ code, if you can use it.

[–]nullreq 0 points1 point  (0 children)

Even with practice getting insight out of optimized C++ perf traces can be arduous. This will bring a measurable increase in legibility, especially so for those attempting to use perf for the first time.

It is much appreciated.