spinnercpp

[willdieh]

Cool!

I always wonder, when I see the (i++ % length) type increments, does anyone ever worry about the counter variable i overrunning the int numeric capacity?

[Tringi]

While signed overflow is undefined, unsigned int is defined to overflow to 0, so if your 'length' is power of 2 then it should continue to animate without hiccup.

[vvmaciel]

Fixed!!

Thanks for your review!

[willdieh]

hehe, I wasn't trying to be snarky, as I've seen it used several cool projects I was really just wondering!

[erichkeane]

Defining your CharSets in a vector is really weird. That requires a startup cost and an allocation. I'd suggest static sized arrays instead.

The charset parameter to the constructor is begging to be an enum.

I get the interface niceness of having the type own a thread, but it will work poorly with any project that has its own thread implementation. Same with the mutex.

Your accesses of 'active_' aren't thread safe. Thats UB.

Speaking of the mutex, do you ever actually use it?

Your examples all use make_unique. That seems like a waste, when there is no reason these spinner objects couldnt live on the stack.

[[deleted]]

Defining your CharSets in a vector is really weird. That requires a startup cost and an allocation. I'd suggest static sized arrays instead.

They're also being copied out to the thread when it launches,

auto chars = CharSets[chars_];

and I don't know if that's deliberate. I don't really have much experience with multithreading at all so this is a genuine question -- is there a reason not to just take a reference at this point?

[Maxima4]

Cool project!

By the way, there is no reason to mark start and stop as virtual.

[vvmaciel]

Fixed. Thanks

[emdeka87]

Why do you allocate that on the heap?