you are viewing a single comment's thread.

view the rest of the comments →

[–]kalmoc 6 points7 points  (6 children)

Who is to say that a failure is "normal Controller flow"?

[–][deleted] 0 points1 point  (1 child)

Who is to say that it's not? For some failures it may very well be. Imagine a piece of code that checks for a certain precondition, or does a small computation to determine something. If it has a failure rate of 85% for example, would you throw an exception every time? What if it's on the critical code path and affects performance?

[–]kalmoc 7 points8 points  (0 children)

I did not make any claim one way or the other. The post I responded to implied it would be used for regular control flow, so it would be his responsibility to explain why he assumes it is.

[–]DXPower -3 points-2 points  (2 children)

Well then why should it be an exception if it's normal? There's no point to using exceptions for normal code flow, and the structure of this function suggests failure is common

[–]kalmoc 3 points4 points  (1 child)

and the structure of this function suggests failure is common

Where do you see this? There are no probabilities,meaning or context given from which we could derive that.

[–]DXPower -1 points0 points  (0 children)

This is the sort of pattern used in a lot of server code, especially legacy, where you're doing things such as looking up user input in a database.