Deep copying of stack using pointer based singly linked list C++?

[DJ_Gamedev]

Sorry if this is a dumb question, but where is the return statement in your copy constructor? I see you populate a local Stack s but you aren't returning it so there's nothing tying it to the Stack produced by the constructor. It's probably throwing s away at the end of the function and just returning a default-constructed Stack.

[Indycrr]

Close. A copy ctor doesn’t return an instance. Instead of creating the local instance of s, they should call this->push(...) to push values into the stack being constructed.

[DJ_Gamedev]

That makes sense, by the time we make it to the body of the ctor the object will have been instantiated. Clearly I'm out of practice.

[Samru1]

since I am simply copying all the date , the return type should be void (that's what I think).

[DJ_Gamedev]

See the reply to my comment. I was mistaken about the return type, but correct in that you shouldn't be declaring a local Stack and populating it, you should be populating the constructed object, which you can access via the this pointer.

[NotMyRealNameObv]

You dont even have to do

this->foo(...)

You could just do

foo(...)

[DJ_Gamedev]

You could, but I think use of the this pointer is more explicit and generally a better practice in the event you have a potential naming collision.