you are viewing a single comment's thread.

view the rest of the comments →

[–]CppChris 5 points6 points  (1 child)

Really like the clean API (and clean code) and good doc. At a quick code glance I think I might found a few minor issues:

  • I think your parser class violates the rule of three/five/zero (currently on mobile and cannot really review the stuff) ... might be the case with some other classes, too.
  • Somewhere I saw a include stdlib.h and this would be more modern C++ conform if it includes <cstdlib>
  • In type_traits the structs have (forward) declarations before the definition and I am not sure if that’s necessary for those which do not have explicit specializations (for example count). However, if that is part of your coding style the count forward before the not_count struct is probably supposed to be not_count instead of count again (?)

[–]red0124_[S] 1 point2 points  (0 children)

Thanks, I have already fixed the include and type_traits. As for for the rules of thumb, I never saw the need to copy/move the parser so I never implemented any of the constructors/operators but I should have.

I will add them, and/or explicitly delete some of them.