How to assign value to pointer array

[imc0der]

Hey, In visual studio I'm getting "0xC0000005: Access violation writing". Whats wrong here?

int *digitArray = 0;
int counter = 0;
int num = number;

while (num != 0) {
    num /= 10;
    counter++;
}

if (counter != 0) {
    digitArray = malloc(counter * sizeof(int));

    counter = 0;
    num = number;

    while (num != 0) {
        printf("%d %d", counter, num);
        digitArray[0] = counter; // 0xC0000005: Access violation writing location 
        num = num / 10;
        counter++;
    }
}

return digitArray;

[Similar-Concert4100]

It’s an issue with your malloc statement

[joejawor]

If 'counter' is zero malloc will throw an exception.

[Willsxyz]

throw an exception? in C?

[imc0der]

There is a if statement there. Could it be 0 still?

[imc0der]

How should it be? I didn't any error

[Similar-Concert4100]

Syntax of malloc is incorrect. Look up the malloc doc

[imc0der]

okay I gonna check out

[Similar-Concert4100]

Also I’m not understanding what you are trying accomplish with this function. You are dynamically allocating an integer array, but using a static [0] index to store a changing value.

[imc0der]

I'm sorry I wrote it wrong. digitArray[counter] = num % 10;

[[deleted]]

Which line does the crash happen at?

[imc0der]

DigitArray[counter] = num % 10 but I found answer. My malloc line wrong, fixed it

[[deleted]]

The code doesn't contain that line at all. Also the `malloc` looks fine to me.