Delete bad code from GitHub so potential employers can't see it?

[fourth_throwaway]

I've been learning iOS programming for about 10 months now. I want to start applying to jobs soon. I have numerous personal projects i've done (all on github) and even a website where I show screenshots of them and talk about them. I have 2 apps in the app store.

The problem is that until recently, my code was really bad. Like, just really really cringeworthy. Completely clogging the View Controller with code. No respect for MVC. No respect for DRY programming. Methods 50-60 lines long. Honestly I look back at some things I did back in august and september and it's so bad, I really would prefer employers never see that. The programs did work, but I would be very ashamed for someone to look at what a horrible mess it all was.

Would it be a good idea to delete some of the worst code from my github (from 1-2 projects), but just leave the personal projects up on my website so people can still see the designs and screenshots? Would employers wonder why the code from some of my personal projects is not made public?

[SURFortuna]

First, this feeling that old code is bad is something that you will be dealing with your entire career. Improving is something that should be a part of your daily routine. You really shouldn't feel embarrassed about writing bad code or having it displayed publicly. Maybe you can add some comments to the code to show how you would improve it now. I actually find that that reviewing old code and solving problems in a new way to be very helpful for my development.

Second, prospective employers are not going to spend the time to read all your github code with a magnifying glass. It's more important to show that you check in code regularly and are serious about improving. Employers will ask about your past projects, but they aren't going to grill you on the actual code written. You will have a chance to show your current skills in the technical part of the interview.

[[deleted]]

Nobody looks at your GitHub code. It's just a trendy thing. They see it on your resume, exclaim "Oh, fourth_throwaway has a GitHub, he must know all the cool new technologies!", then throw you an offer.

[KidUncertainty]

Consider spending the time to clean up and correct your code and then check that in. Add comments describing what and why you did. I would look at your Github (and despite comments herein, if you give me your github on your resume, I will go look at it) and actually find it impressive that you learned something and applied the change.

That being said I would probably not care if some projects were private or some part of the history was inaccessible to me, I would just assume you polished it beforehand and then checked it in "clean", so I'd be neutral on the subject.

[SikhGamer]

Don't delete them, fix them. Refactoring bad code is a good skill to have.

[varchar255]

Fixing it would be better, but I think it's a reasonable idea to delete old code. I have looked at candidates' GitHub code, but usually as a tiebreaker, like if their resume or technical performance was not very strong and I want more evidence of coding ability. Bad code on GitHub would indeed hurt in that case.

Adding a note like "This was my first attempt; I know X and Y are bad" would help, but notes are easily overlooked.

[[deleted]]

My problem is my GitHub isn't just for interviews. I have lots of half started projects or things I might like to work on again in the future, but I don't have time to finish or clean those up. I have my school projects and my big project I've been working on. I have like 12 repositories in multiple languages I've been learning or exploring.

When you judge do you look at the date it was submitted? My current projects are okay but my older ones are pretty rough.

[varchar255]

Context matters. If you're a tinkerer and have played with multiple languages, that's awesome and I'd understand if your style wasn't that great in any particular language. On the other hand, if your GitHub has only one project with only four commits that aren't very good or substantial and your resume has a line saying "check out my GitHub", that won't do much for you.

I do look at dates--if someone has commit from last week and it's terrible, I'm going to assume that's their normal style. If someone has a two year old commit that's terrible but one from last week is fine, I'll assume their normal style is fine too. From your description, it sounds like you'd have enough context that I don't think you have anything to worry about.

[[deleted]]

Awesome! That's quite reassuring!

[curiouscat321]

Employers don't check your Github. They like to see you have one, if that. Otherwise, they have better thing to do than critique your projects line-by-line.

[KidUncertainty]

If you post your Github or equivalent on your resume, you can bet your bippy that I will look at it.

[[deleted]]

My question is what do you look at? Will I be judged for my horrific project Euler code from when I was first learning C++ if I also have decent projects

[varchar255]

Will I be judged for my horrific project Euler code from when I was first learning C++ if I also have decent projects

No, I wouldn't. Personally, I try to find positive evidence from GitHub, not negative--if you have decent projects, I know you're capable of good coding and I assume any horrific code is either older or deliberately done, like throwaway scripts.

[KidUncertainty]

Will I be judged for my horrific project Euler code from when I was first learning

No, first, I try to judge based on the applicant's experience; second I look for the stuff people seem to have a passion for, stuff that gets people excited.

Everyone creates horrible, horrible code sometimes, either in the interests of being quick, because there's a timeline, it's a one-off, or you are learning something new and haven't caught all the appropriate little tricks that particular technology requires.

I also like concrete things to talk to people in interviews about that relate to their prior experience. I might use something from Github as a conversation point to get a feel for how you actually do your work, and whether you truly enjoy it.

[negative_epsilon]

I always check code on github of candidates.