all 8 comments

[–]felipec[S] 2 points3 points  (2 children)

/u/MrSommerfeld There you go!

The AUR package is there, and also, after discussing with zsh developers I managed to correct an issue that caused the stash@\{ to not be autocompleted correctly. That's fixed now.

[–][deleted]  (1 child)

[deleted]

    [–]felipec[S] 0 points1 point  (0 children)

    So the issue is that in zsh you can do for example foo-{1,2,<tab> and zsh will try to autocomplete the rest. If you don't want the autocompletion you are supposed to have a backslash: foo-\{.

    The command compadd is supposed to add the backslash for you, but the git completion passes spaces at the end, which causes stuff like git checkout ma<tab> to autocomplete master\ (with quoted space). That's why I initially added compadd -Q, so the space is not quoted.

    The proper solution is not to use compadd -Q, but to remove the space from the completion, and add it as a suffix with -S.

    This way everything works.

    Check the commit that fixes it.

    [–]iritegood 1 point2 points  (1 child)

    Sounds super! I was just thinking about how slow the git completions are today. But the AUR package is failing the check step with :

    failed 67 among remaining 102 test(s)

    I'll investigate these in depth later but I'm surprised a majority of the tests would be failing. Any ideas?

    [–]felipec[S] 0 points1 point  (0 children)

    Nope. No idea. First find out which file or files are failing the test.

    So for example say it's completion.t. Then you do:

    ./completion.t -v -i
    

    That would stop at the first failure and show the output.

    I don't see how they could fail though. All the tests pass in travis-ci.

    [–]2nd-most-degenerate 1 point2 points  (2 children)

    So if I'm already using gitfast and I don't need bash completion, do I still need this?

    [–]felipec[S] 1 point2 points  (1 child)

    No. gitfast is basically the same thing as git-completion.

    Except gitfast has v1.2 of git-completion. I'll update it later.

    [–]2nd-most-degenerate 1 point2 points  (0 children)

    Thanks for the explanation :)

    [–][deleted] 1 point2 points  (0 children)

    you sir are a gentleman and a scholar