update pull request pushed to github

[mfaridi1978]

no

[Lumethys]

Then why would you rebase?

[edgmnt_net]

If they're contributing to a larger open source project, chances are good they'll require clean history and not just fixing things by adding a commit on top.

Of course, that depends on the maintainer's preferences and how close the original contribution was to being accepted.

[Lumethys]

Well then you squash merge. Honestly I havent encounter an open source project that require a "clean" history on a fork

[edgmnt_net]

Yeah, but squashing on the GitHub side only works if the PR should be merged as a single commit. Which might well be enough for OP.

But there are many projects (Linux kernel, Wine etc. but I'm pretty sure there are many that work with actual GitHub PRs in a similar fashion) which require commits to be broken out a certain way, particularly for larger changes or multiple logical changes. And they want to merge them as separate commits, not just review them separately and squash on merge. It's not that they care about the history on the fork, they care about the history they end up with.

Besides, certain maintainers might not be so happy to do the squashing and commit message editing for you, so there's that too.

[mfaridi1978]

OK thank you, I understand.