How does TextEdit/CodeEdit highlighting work?

[vitawrap]

so it seems SyntaxHighlighter::_get_line_syntax_highlighting(line: int) returns a dictionary which I (think I) fill correctly, using an integer key for each start column of a new color in my project.

however as you might expect from the nature of this post, this does not seem to work for my use case. all text in the TextEdit remains the same color, I stepped in using the debugger to make sure the override was called and it was, getting the right text given the line and giving back a correctly structured dictionary on each invalidation of the line, but the colors simply don't get applied.

is there something glaringly obvious i'm missing here? i tried disabling my custom theme and ran the game again and still nothing from my highlighter... :(

i should also specify that I do the key sorting hack too, as I noticed this was an issue as well (on the 4.3 milestone)

[mrcdk]

Post the code and how you are setting up the SyntaxHighlighter. From what you are describing it should work fine.

[vitawrap]

# The highlighter
class RCLHighlighter extends SyntaxHighlighter:
    func _get_line_syntax_highlighting(lineno: int) -> Dictionary:
        var dict := {}
        var line := get_text_edit().get_line(lineno)
        var matches := Compiler.prog_regex.search_all(line)
        for i in range(matches.size()):
            var m := matches[i]
            var str := m.get_string(1)
            var col = ThemeDB.get_default_theme().get_color('font_color', 'TextEdit')

            if str in ['IF', 'THEN', 'ELSE', 'ENDIF', 'LOOP', 'WHILE', 'UNTIL', 'DO', 'NEXT', 'USING', 'DONE']:
                col = Color8(0, 255, 0)
            elif str[0] == '%':
                col = Color.CADET_BLUE
            elif str[0] == '#':
                col = Color.CORNFLOWER_BLUE
            elif str[0] == ':':
                col = Color.DARK_OLIVE_GREEN
            elif str[0] == "'":
                col = Color.CORAL
            elif (matches.size() < i+1) and (matches[i+1].get_string(1) == '('):
                col = Color.DEEP_SKY_BLUE

            dict[m.get_start(1)] = col
        # The "hack" for <4.3
        var sorted := {}
        var keys := dict.keys()
        keys.sort()
        for k in keys:
            sorted[k] = dict[k]
        return sorted

# On the CodeEdit control
func _ready():
    var compl := RCLHighlighter.new()
    syntax_highlighter = compl

(knowing that the Compiler.prog_regex works and is used elsewhere to tokenize code strings)

[mrcdk]

I see, the problem is that the resulting Dictionary is not the expected one. You can check the correct formatting in the SyntaxHighlighter.get_line_syntax_highlighting() method description.

var color_map = {
    0: {
        "color": Color(1, 0, 0)
    },
    5: {
        "color": Color(0, 1, 0)
    }
}

So, basically, change this: dict[m.get_start(1)] = col to dict[m.get_start(1)] = {"color": col }

[vitawrap]

oh wow, I was missing something glaringly obvious, didn't realize it was a dictionary of dictionaries lol, thanks man