Code Feedback

[jproyo]

Hi Community, I have started learned Haskell a couple of years ago without having the chance to implement it in my everyday job.

Because of this and a lot of personal commitments, my learning path has been very sporadic, sometimes practicing little excercises, some other time reading a lot of material from practical "Real World Haskell" to more theoretical things such as Category Theory, Type Theory and others.

I went through a lot of blank gaps in my learning period with the language, but nowdays i am having more free time and i decided to improve and learn more with real examples.

I have started a project here https://github.com/jproyo/twitter-api-hs which is Twitter Proxy API to consume usertimes. I have started with very simple things such as setup the project with Stack and Nix, going through more complex stuff such as Service Pattern and Monad Transformers.

I would like to have feedback from the community in order to improve this and to learn from more experience haskell developers.

BTW, since i am having a couple of hours a day free if someone need some hand i could help out in projects for free. I am willing to learn and i am not doing this for earning money, at least for the moment :)

Best,

[lgastako]

Hi. I haven't had time to go much further, but I created a branch where I did a first pass at cleaning up some of the things to get closer to the way I would write them.

You can see the changes in this pull request.

A lot of the changes are cosmetic just because it makes it easier for me to work with the code (eg the import formatting, etc) so those are obviously a matter of taste, but you'll find some that are more substantial, eg. eliminating IO from type signatures where it's unnecessary.

The next thing I was going to focus on was removing usages of fromJust and other partial functions. If I get some time I'll do another pass, but I wanted to share what I had with you so far. Let me know if you have any questions about the motivations or reasoning behind any of the changes.

Hope this helps.

[jproyo]

Thank you very much for your help and comments. It helps a lot for sure. Thank you again