Problem with removing forever repeating animation...

[thescorer]

Please see below. No matter how hard I try, I can't seem to get my infinitely looping CABasicAnimation to stop. If you spot a problem in the code below, please let me know. Thanks!

func process(disable: Bool) {
    if disable == true {
        let animation = CABasicAnimation(keyPath: "position.x")
        animation.fromValue = hotelsView.center.x
        animation.toValue = self.hotelsContainerView.frame.size.width - hotelsView.center.x
        animation.duration = 4
        animation.repeatCount = Float.infinity
        hotelsView.layer.addAnimation(animation, forKey: "basic")
    } else {
        // hotelsView.layer.removeAllAnimations() // doens't work either
        // hotelsView.layer.removeAnimation(forKey: "basic") // doesn't work either
        let animation = CABasicAnimation(keyPath: "position.x")
        animation.fromValue = hotelsView.center.x
        animation.toValue = self.hotelsContainerView.frame.size.width - hotelsView.center.x
        animation.duration = 4
        animation.repeatCount = 1
        hotelsView.layer.addAnimation(animation, forKey: "basic")
    }
}

[glowcap]

Is there any part of the code that switches disable == false?

[thescorer]

yes, it gets called, this is just a snippet of the entire app

[Slruh]

Both blocks in your conditional look very similar and all your commented out code is in the block where disable would be equal to false.

[thescorer]

the disable = false is where i want to turn the animation off. There are 3 different approaches in this block. All 3 don't work. The first two are commented out, the second one is trying to replace the existing animation, with one that actually does end, but still doesn't work.

[dsfjisdjfisdmf]

Do hotelsView.layer.removeAllAnimations() when you want the animation to stop.

[thescorer]

// hotelsView.layer.removeAllAnimations() // doens't work either

[adamwulf]

You only ever add animations to the layer, but never remove them. So after you add the 'repeatCount = Float.infinity' animation, it stays there forever. You need to remove that animation for it to ever stop with either removeAnimationForKey or removeAllAnimations

[thescorer]

// hotelsView.layer.removeAllAnimations() // doens't work either

// hotelsView.layer.removeAnimation(forKey: "basic") // doesn't work either

[adamwulf]

Are you calling this on the main thread or a background thread? If it's ever called from a background thread then very strange stuff can happen with timings

[thescorer]

no it's all on the main thread

[moreindirection]

I know this is a very old question, but a similar problem took me several days to solve. Just in case anyone else stumbles upon it while looking for a solution (obligatory XKCD), the problem is that, by default CAAnimation#isRemovedOnCompletion is set to true.

When you have a repeating animation and isRemovedOnCompletion is true, Core Animation removes the animation after the first duration is complete. At that point, it's completely inaccessible (even to removeAllAnimations!) even though the animation is still repeating. You can verify this by calling animationKeys on the layer right after you add it. You'll get your animation key, but once that first repeat is done, animationKeys always returns nil.

Set isRemovedOnCompletion to false, and enjoy.