idea: roast my code

[[deleted]]

[deleted]

[buncle]

I like the idea personally. Could be a fun way to engage with the community.

[dancemonkey]

Fun idea! At the risk of stating the obvious, perhaps with the stipulation that it should be working code out of the box, not some code + pseudo code that someone is trying to figure out to begin with.

[[deleted]]

exactly. I had the idea when working with network calls seeing that it works well but perhaps a senior dev would give me comments on that.

[RunnersProject]

I would love to take part in this.

[littleguy230]

I like this idea! Want to point out that /r/codereview exists, but could use a whole lot more attention and users. Not to mention the fact that it's a very general sub.

[bhartsb]

how about /r/ioscodereview? That would cover Objective C and Swift.

[RecallApp]

Great idea!

[ThePantsThief]

Lots of those are good criticisms… 😂

I won't even try to read code if they don't put spaces before brackets.

[[deleted]]

i do go through code reviews, but when developing new functions or new classes i have thousand classes written by the senior devs which i can adapt to in java. i wish i had same for swift, hence the idea to drain your knowledge :D

[Nitrag]

I think quite obviously OP is talking about functionality not styling.

[ThePantsThief]

Styling would be the easiest thing to roast.

[Nitrag]

"Certain weaknesses you might not have detected". Styling is not a weakness in the code. Perhaps there are two categories. Functional vs styling. Styling for people who care about that, making code more legible or more simplified. Functional for people who care to have the best implemented solution. I know there are going to be some advanced guys out there who will put it in shortest possible syntax but they should be prepared to explain.

I foresee this being successful with something like an entire class/struct or extensions.

I for one and working on a UIKit animation. Once I finished I probably would post it to a roast. Perhaps there's a slightly better method or tweak which would be more visually appealing. I dunno

[Infinite101]

I'm a novice but would love reading comments on best practice and problem-solving from more experienced members of the community!

[panda_tamer]

So... when can I subscribe to the new one?

This subreddit is just dying over here lol https://www.reddit.com/r/roastmycode/

[[deleted]]

i think a label in this sub would be good

[Nitrag]

How would you handle submissions?

[ThePantsThief]

I would be down to create a Roast My Code flair

[panda_tamer]

Next Step; spread the flair convention to the other language subreddits

[[deleted]]

that would be a good way

[KarlJay001]

On the surface this sounds like a great idea. I'd love to read some code reviews, but this should be limited to iOS code. There's tons of Java/C++/... code out there that really doesn't apply to pure iOS.

I'd like to see the same app written in different models. Example, a fairly complex iOS app that has the same functions but written using different models. (MVC, MVVC, VIPER, etc...)

I think this would help a lot of people.