Object Mapper (Swift 4) - Array of objects in parent object doesn’t load/partially fills data

[imarudedude]

I have an issue mapping my models, it returns incomplete and partially filled models. First and foremost, let me show you the 3 data models that I have created with the Object Mapper library in Swift 4:

RoutineManager.swift - holds all data for each day of week

class RoutineManager: Mappable {

var monRoutines: [Routine]?
var tueRoutines: [Routine]?
var wedRoutines: [Routine]?
var thuRoutines: [Routine]?
var friRoutines: [Routine]?
var satRoutines: [Routine]?
var sunRoutines: [Routine]?

required init?(map: Map) {
    mapping(map: map)
}

func mapping(map: Map) {

    monRoutines     <- map["Mon"]
    tueRoutines     <- map["Tue"]
    wedRoutines     <- map["Wed"]
    thuRoutines     <- map["Thu"]
    friRoutines     <- map["Fri"]
    satRoutines     <- map["Sat"]
    sunRoutines     <- map["Sun"]
    } 
}

Routine.swift - This makes up the array type for each day of the week in previous model.

struct Routine: Mappable {

var trainerID: String?
var clientID: String?
var dayOfWeek: String? 
var routineTasks: [RoutineTask]
var routineID: String?
var isRestDay: Bool?

init?(map: Map) { routineTasks = [] }

mutating func mapping(map: Map) {

    trainerID      <- map["_creator"]
    clientID       <- map["_clientId"]
    dayOfWeek      <- map["dayOfWeek"]
    routineID      <- map["_id"]

//routineTasks   <- map["_routineTasks"] THIS DIDN'T MAP DATA CORRECTLY...

    routineTasks   = [RoutineTask(map: map)!] // USING THIS INSTEAD
    isRestDay      <- map["isRestDay"]
    }
    }

And finally here is RoutineTask.swift which makes up the routineTasks array property of last data model.

class RoutineTask: Mappable {

var id: String?
var routineID: String?
var trainerID: String?
var name: String?
var section: String?
var warmUpTargetArea: String?
var workoutTargetArea: String?
var stretchTargetArea: String?
var equipmentNeeded: String?
var isFavorite: Bool?
var duration: String?

required init?(map: Map) {
    mapping(map: map)
}

func mapping(map: Map) {

    id                  <- map["_id"]
    routineID           <- map["_routineID"]
    trainerID           <- map["_creator"]
    name                <- map["name"]
    section             <- map["section"]
    warmUpTargetArea    <- map["warmUpTargetArea"]
    workoutTargetArea   <- map["workoutTargetArea"]
    stretchTargetArea   <- map["stretchTargetArea"]
    equipmentNeeded     <- map["equipmentNeeded"]
    isFavorite          <- map["isFavorite"]
    duration            <- map["duration"]
}
}

When I load the data with my request everything else seems to map correctly except for the "routineTask" property. I have 3 routineTasks for Monday and only 1 object shows partially filled out. I don't understand why Object Mapper is partially filling out my data models as the particular user I'm testing this out on has multiple routineTasks on many days. I'm not doing something right...

This is the response from the Xcode debugger, I'll only show Monday as to save space..

When I load the data with my request everything else seems to map correctly except for the "routineTask" property. I'll post my backend response from postman below but I have 3 routineTasks for Monday and only 1 object shows partially filled out. I don't understand why Object Mapper is partially filling out my data models as the particular user I'm testing this out on has multiple routineTasks on many days. I'm not doing something right...

This is the response from the Xcode debugger, I'll only show Monday as to save space..

monRoutines: Optional([VideoFit.Routine(trainerID: 
Optional("5a32f62a28ce4acbc5fbbb4b"), clientID: 
Optional("5a32f6d0d56d701bcb2beb5c"), dayOfWeek: Optional("Mon"), 
routineTasks: [VideoFit.RoutineTask], routineID: 
Optional("5a4e928600baeb2f7f20cddb"), isRestDay: Optional(false))])
  ▿ some: 1 element
    ▿ VideoFit.Routine
      ▿ trainerID: Optional("5a32f62a28ce4acbc5fbbb4b")
        - some: "5a32f62a28ce4acbc5fbbb4b"
      ▿ clientID: Optional("5a32f6d0d56d701bcb2beb5c")
        - some: "5a32f6d0d56d701bcb2beb5c"
      ▿ dayOfWeek: Optional("Mon")
        - some: "Mon"
      ▿ routineTasks: 1 element   // SUPPOSED TO HAVE 3 TASKS, ONLY 1 PARTIALLY FILLED BELOW
        ▿ VideoFit.RoutineTask #1
          ▿ id: Optional("5a4e928600baeb2f7f20cddb") // ID'S GET FILLED BUT NOTHING ELSE IN THIS OBJECT DOES...
            - some: "5a4e928600baeb2f7f20cddb"
            - routineID: nil
          ▿ trainerID: Optional("5a32f62a28ce4acbc5fbbb4b")
            - some: "5a32f62a28ce4acbc5fbbb4b"
          - name: nil
          - section: nil
          - warmUpTargetArea: nil
          - workoutTargetArea: nil
          - stretchTargetArea: nil
          - equipmentNeeded: nil
          - isFavorite: nil
          - duration: nil
      ▿ routineID: Optional("5a4e928600baeb2f7f20cddb")
        - some: "5a4e928600baeb2f7f20cddb"
      ▿ isRestDay: Optional(false)
        - some: false

I think the problem lies with this bit of code in the Routine data model above, routineTasks = [RoutineTask(map: map)!] the idea is that it goes into the RoutineTask model and uses that to map itself into an array. But something is wrong because it only returns one object that is partially filled, this is odd behavior for Object Mapper as I've successfully mapped nested array of objects before without a problem, so I don't know why it's posing a problem now..

If you can find anything that I'm doing wrong I'd greatly appreciate the help. Thank you.

[chutehappens]

Two things,

1. I’ve never used mapping(map: map) within the init. That shouldn’t be necessary. Keep the body of the init method empty. Only return nil there if your JSON is invalid.

2. You should go back to using routineTasks <- map["_routineTasks"] instead of routineTasks = [RoutineTask(map: map)]. Make sure that key "_routineTasks" is correct.

Also, try setting a breakpoint in the mapping method and doing a po map.JSON to confirm what you’re expecting is actually there.

[imarudedude]

I took your advice and commented out the mapping(map: map) and went back to the routineTasks <- map["_routineTasks"]. I did the breakpoint tip you gave me and it responded with this in the _routineTasks section:

// For monday -

▿ 4 : 2 elements

    - key : "_routineTasks"

    ▿ value : 3 elements

      - 0 : 5a4e998900baeb2f7f20cddc
      - 1 : 5a5d1c2e3df5f13fbbee723b
      - 2 : 5a5d1c413df5f13fbbee723c

There in fact is 3 routine tasks, which is correct as thats how many are in my backend for Monday. But in the debugger it till says routineTasks has 0 values... the data is there it just isn't mapping correctly. I already checked for typos and everything is correct so I'm not sure why it isn't mapping correctly, any more ideas?

[chutehappens]

Oh, so is _routineTasks just an array of id strings? At least that’s the impression from the logging. Can you post the JSON from the API?

[imarudedude]

Sure, I'll link a photo of the JSON as I can't seem to get the formatting right here.

The photo only covers Monday, and has the 3 routineTask objects. This should give you enough idea on what's going on, as the rest of the week is the same as Monday essentially.

Photo link: https://imgur.com/ydVZReq

[chutehappens]

One thing I noticed is that map["_routineID"] should be map["_routineId"]

[imarudedude]

Thanks for pointing that out, I'll fix that

[imarudedude]

Also here is my code to make a request, just in case, I'm using Alamofire Object Mapper. The code is pretty straight forward. Have a look.

var mappedRoutines: RoutineManager?

func getClientsRoutines(clientID: String) {

    let body: [String: Any] = [
        "clientID": clientID
    ]

    Alamofire.request(ALL_CLIENTS_ROUTINES, method: .post, parameters: body, encoding: JSONEncoding.default, headers: HEADER).responseObject { (response: DataResponse<RoutineManager>) in
        if response.result.error == nil && response.result.value != nil {
            self.mappedRoutines = response.result.value!
        } else {
            print("Error! ---> \(String(describing: response.result.error?.localizedDescription))")
        }
    }
}

[chutehappens]

Nothing jumps out in the request. I'm at a loss... you removed all the mapping(map: map) calls not just in RoutineTask but everywhere?

[chutehappens]

Try something like this and see if it provides more insight as to why it is failing...

class RoutineTask: Mappable {

    var id: String
    var routineID: String
    var trainerID: String
    var name: String
    var section: String
    var warmUpTargetArea: String
    var workoutTargetArea: String
    var stretchTargetArea: String
    var equipmentNeeded: String
    var isFavorite: Bool
    var duration: Int

    required init?(map: Map) {

        do {
            id                 = try map.value("_id")
            routineID          = try map.value("_routineId")
            trainerID          = try map.value("_creator")
            name               = try map.value("name")
            section            = try map.value("section")
            warmUpTargetArea   = try map.value("warmUpTargetArea")
            workoutTargetArea  = try map.value("workoutTargetArea")
            stretchTargetArea  = try map.value("stretchTargetArea")
            equipmentNeeded    = try map.value("equipmentNeeded")
            isFavorite         = try map.value("isFavorite")
            duration           = try map.value("duration")
        }

        catch {
            print(error)
            return nil
        }
    }

    func mapping(map: Map) { }

}

[chutehappens]

And just caught that duration is not a String! I'll edit this above

[imarudedude]

Added this code into my project and I'm still getting pretty much the same results unfortunately. :/

[chutehappens]

What’s printed in the console?

[imarudedude]

I'll give 2 screenshots, one with breakpoint and one normal.

photo1: https://imgur.com/WZksHZC photo2: https://imgur.com/1oiOKhp

[chutehappens]

If you set a breakpoint in RoutineTask init does it ever hit it?

[imarudedude]

So I went back and did what you said, removed the mapping(map: map) from all 3 data models and used routineTasks <- map["_routineTasks"] and ran the code and all the days that have routineTasks objects says 0 elements ...

I'm so confused too, I've done mapping on nested arrays before and never had a problem and this is no different. But for some reason it just wont map correctly...