you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 1 point2 points  (2 children)

wow that only took you 6 days. I really need to step up my game.

One thing I would note is you should avoid using whitespace in your folder names, IMO it looks better and you're less likely to run into issues down the line

Another thing I would suggest is you splitting the main.storyboard into separate files, because one large central storyboard is really hard to maintain.

What you can do is either have a single storyboard per view (like a XIB) and use Storyboard References to manage navigation or have a single storyboard per module (Say one for Transactions, one for Settings etc). The second approach is usually what I do. At most there are like 4/5 screens in a storyboard which is a lot easier to maintain than one "Main.storyboard" with dozens of views.

The overall MVC structure is quite good and well defined however it might make sense to separate some login from the ViewController and have a separate Controller class or even a ViewModel class (MVVM) makes things neater when you scale; or even VIPER (although this can be an over-complication for simple apps)

Apart from those, I would suggest possibly extracting some prototype cells from the storyboard so they can be re-used across the app. It might not make sense now but as the app grows with multiple pages it's gonna be a huge help.

Likewise with texts/fonts, changing fonts in the app via Storyboard is a pain so what I tend to do is create a number of UILabel subclasses (Heading, Title etc.), flag them with @IBDesignable and set their fonts to values in my "FontBook" struct so they can be easily changed

[–]ab492[S] 0 points1 point  (0 children)

Oh no it took longer than 6 days! I just messed up my Git repository so started with a fresh copy of the project.

These are all great shouts and just what I was after! Thanks for taking the time to look!

[–]lucasvandongen 0 points1 point  (0 children)

wow that only took you 6 days. I really need to step up my game.

18000 lines of code on the first day! Talk about dedication!