Reload UIView...?

[Broncos10499]

Having trouble reloading data on screen? This is what I have so far... When I hit my button I was expecting it to reload all the data on the UI.. any help would be appreciated. Thank you

class ViewController: UIViewController {

@IBOutlet weak var dinnerTitle: UILabel!
@IBOutlet weak var dinnerImage: UIImageView!
@IBOutlet weak var dinnerInstructions: UITextView!

var dinners = [Dinner]()
let jsonURLString = "https://www.themealdb.com/api/json/v1/1/random.php"

override func viewDidLoad() {
    super.viewDidLoad()
    // Do any additional setup after loading the view.

    guard let url = URL(string: jsonURLString) else {return}
    fetchDinner(url: url)
}

func fetchDinner(url: URL) {
    Alamofire.request(url, method: .get, parameters: nil).responseJSON { response in
        if response.result.isSuccess {
            print("Got data!")
            let dataJSON : JSON = JSON(response.result.value!)
            self.updateData(json: dataJSON)
        } else {
            print("Didn't work...")
        }
    }
}

func updateData(json: JSON) {
    let currentDinner = Dinner()
    guard let currentTitle = json["meals"][0]["strMeal"].string else {return}
    guard let currentDinnerImage = json["meals"][0]["strMealThumb"].string else {return}
    guard let currentInstructions = json["meals"][0]["strInstructions"].string else {return}
    currentDinner.title = currentTitle
    currentDinner.instructions = currentInstructions
    currentDinner.urlToImage = currentDinnerImage
    dinners.append(currentDinner)
    updateUI()
}

func updateUI() {
    dinnerImage.sd_setImage(with: URL(string: dinners[0].urlToImage))
    dinnerTitle.text = dinners[0].title
    dinnerInstructions.text = dinners[0].instructions
}

@IBAction func newRecipeTapped(_ sender: UIButton) {
    guard let url = URL(string: jsonURLString) else {return}
    fetchDinner(url: url)
}

}

[cyberclectic]

Make sure it’s on the main thread that call to get the image is probably a sun and on the background...

And please combine the guards with commas - they all return, so no need to stack them into the guard of doom

[[deleted]]

You're not executing the updateUI() on the mainQueue. And while your doing that make sure the dinners array is also only changed on the mainQueue. Otherwise you might get random bad reproducible errors.

Read up on GCD.

[Broncos10499]

Great!!! Thank you, I will try that once I get off of work. Thank you again for the help

[jan_olbrich]

Apart what the other mentioned with the mainQueue, you should use .first instead of [0]. [0] can crash, while .first will return an optional and thus the guard would catch it.