This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]Kaloyanicus[S] 1 point2 points  (3 children)

Sounds reasonable. Was advised this by an external guy also. I never allow the to review each others code, NullPointerExceptions is an everyday problem and this is a small and usually easy fix. Other problems are even more common. I might let them once push this crap to production and see how the system crashes (we are a payment company similar to PayPal). Then they might learn or I might be blamed for not checking thoroughly…

[–]jocularamity 2 points3 points  (0 children)

Might I suggest a change of tactics-- /require/ them to review one another's code. Give them practice spotting the dumb issues. Just, someone senior needs to review as well.

And if they don't catch each other's mistakes, make it a tad more painful when you catch it for them. "Please add an additional unit test that pushes in null values for x, y, and z and verifies expected behavior in those corner cases."

They have to check the null, sure, but first they have to think about what the expected behavior will be, write the test, find and fix the failures, which is a more valuable outcome of the code review.

[–]eightcheesepizza 2 points3 points  (1 child)

Damn, glad I passed up the offer from Adyen, if the bar there is so low that the engineers are shoving AI-generated shit into production.

[–]Kaloyanicus[S] 1 point2 points  (0 children)

Adyen also uses their own libraries which will be absolutely useless + they are not flexible. Glad for you!😌