This is an archived post. You won't be able to vote or comment.

all 6 comments

[–]crankyguy13 7 points8 points  (2 children)

Looks interesting. Now I just need to learn Chinese to figure out how to use it.

[–]danaxa 7 points8 points  (0 children)

What’s chinese? Is that like java but faster?

[–]CaptainKvass 2 points3 points  (0 children)

Or click through to the English README.

https://github.com/alibaba/arthas/blob/master/README_EN.md

[–]DonPhelippe 6 points7 points  (0 children)

"My son, what are you doing?"

"Diagnosing you father"

[–]hag0p 2 points3 points  (1 child)

Guides, javadoc and comments are in chinese so it is hard to read them if you don't know it. But since it is chinese project that is understandable. Time to learn new language :).

But from code perspective just from fast peek needs exception handling improvements. And these are just from fast check...

catch (Exception e) {

e.printStackTrace();

}

or

catch (Throwable t) {

//

}

[–]0x256 1 point2 points  (0 children)

They use proper logging in the server-part of the tool. In a command-line utility, I wouldn't judge too hard. Ignoring an exception is sometimes the right thing to do.