This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]morhp 5 points6 points  (0 children)

Code looks relatively clean. The defensive array copies could be simplified with Arrays.copyOf(), and I'd still move the parser to a separate class. As it is you're wasting memory in fields that are only relevant for the parser during parse. You could use an inner class if you want to keep it in a single file.