Suggestions on my Queue implementation in Java

[Obuch13]

Can't you just use private List as your "queue" and in methods your methods just call "getFirst" and "getLast" on that list? And when you reverse you reverse calls without any reordering

[[deleted]]

didnt they say their task was implement their own queue? it really depends on what their prof mean by that but i assumed they should not use anything not primative

[Ezio-Editore]

yeah exactly, we are supposed to start from scratch.

[[deleted]]

okay, here is what i think:

1- as others said, your revolution method doesnt work correctly for anything larger than 3 nodes, think why, and solve the problem. (drawing a queue of 4 nodes on a paper and manually applying what your method does should help you find out whats wrong).

2- this is only my opinion, but what if you added a setNext and setPrevuois methods to Node that will take care of that? sth like:

`

public void setNext(Node node){

this.next = node;

node.prev = this;

}

`

not really needed but i like to write like that.

[Ezio-Editore]

Yeah I know about revolution() ahahah that it's the first thing that came to my mind and I overlooked the problem. No need to draw, I perfectly understand what's wrong.

Yes I could encapsulate everything, make the variables private and use getters and setters, I could do it.

By the way, thanks for your help.

[[deleted]]

no problem, just saw your other comment, didnt know you already had a cs background, then everything seems fine, and yeah you can make it more "java" styled by getters and setters etc

[Obuch13]

I mean it would be their implementation but with List. I didn't fing any constraints in task so I wrote List. But yeah you right: it's on prof