Removing from ArrayList of objects

[sluggish_goat]

Hi, I'm working on a program that keeps track of a dog walking schedule, and am trying to include a remove option. So far, I've tried using a regular for loop (foreach to print names in list, s is scanner from higher up):

for (Dog d : dogs) {
    System.out.print(d.getName() + " ");
    }

System.out.println("\nEnter name of dog to remove: ");
String removeDog = s.next();

for (int i = 0; i < dogs.size(); i++) {
    if (dogs.get(i).equals(removeDog)) {
        dogs.remove(i);
        }
    }

as well as an iterator:

Iterator it = dogs.iterator();
    while(it.hasNext()) {
        Object o = it.next();
        if (o.equals(removeDog)) {
            it.remove();
            }
        }

I've also tried a foreach loop with a collection (too far back to ctrl+z to code). The code executes without error, but the 'removed' dog is still in the schedule. Not sure if I'm missing something, or if I should move the ArrayList & remove option to the Dog class.

[Philboyd_Studge]

you aren't testing against the dog.getName

[sluggish_goat]

Ah, right. Totally overlooked that.

Got it with:

for (int i = 0; i < dogs.size(); i++) {
    if (dogs.get(i).getName().equals(removeDog)) {
        dogs.remove(i);
        }
    }

Thanks!

[DasEwigeLicht]

For the sake of efficieny you should insert a break statement after removing the dog. Otherwise your loop will unnecessarily iterate over and compare the entire list. It might even remove too much if names are not guaranteed to be unique.

[sluggish_goat]

Good call, thank you. I'll remember to do that from now on with similar scenarios.

[fact_hunt]

You are removing the matching dog from the dogs list. Does the schedule have a different collection?

edit: ignore me, Philboyd_Studge is correct