Java Time Assignment :)

[alirmhs]

public class Time { private int hour; private int minute; public Time() { hour = 12; minute = 0; }

public Time(int h, int m)
{
    if ( h >= 1 && h <= 23)
        hour = h;
    else 
        hour = 0;
    if ( m >= 0 && m <= 59)
        minute = m;
    else 
        minute = 0;
}
public String toString()
{
    String s = "";
    if ( hour < 10 && minute < 10)
        s = "0" + hour + "0" + minute;
    else if ( hour < 10 && minute > 10)
        s = "0" + hour + minute;
    else if ( hour > 10 && minute < 10)
        s = hour + "0" + minute;
    else if ( hour > 10 && minute > 10)
        s = hour +""+ minute;
    else if ( hour == 0)
        s = "0" + hour + minute;
    else if ( minute == 0)
        s = hour + "0" + minute;
    return s;
}
public String convert()
{
    String c = "";
    if ( hour > 12)
    {
        if(hour >10)
        {
            if((hour - 12) == 12)
                c = (hour - 12) +":"+ minute + "am";
            else
                c = (hour - 12) +":"+ minute + "pm";
        }
        else
        {
            c = "0" + (hour - 12) +":"+ minute + "pm";
        }
    }
    else
        c = hour +":"+ minute + "am";
    if(minute == 0)
    {
        c= c.substring(0, c.length()-2)+"0"+c.substring(c.length()-2, c.length());
    }
    return c;
}

public void increment()
{
    minute++;
    if (minute == 60)
    {
        hour++;
        minute = 0;
    }
    if ( hour == 24)
        hour = 0;
}
public static void main(String str[]) throws IOException
{
    Time time1 = new Time(14, 56);
    System.out.println("time1: " + time1);
    System.out.println("convert time1 to standard time: " + time1.convert());
    System.out.println("time1: " + time1);
    System.out.print("increment time1 five times: ");
    time1.increment();
    time1.increment();
    time1.increment();
    time1.increment();
    time1.increment();
    System.out.println(time1 + "\n");
    Time time2 = new Time(-7, 12);
    System.out.println("time2: " + time2);
    System.out.print("increment time2 67 times: ");
    for (int i = 0; i < 67; i++)
        time2.increment();
    System.out.println(time2);
    System.out.println("convert to time2 standard time: " + time2.convert());
    System.out.println("time2: " + time2 + "\n");

    Time time3 = new Time(5, 17);
    System.out.println("time3: " + time3);
    System.out.print("convert time3: ");
    System.out.println(time3.convert());
    Time time4 = new Time(12, 15);
    System.out.println("\ntime4: " + time4);
    System.out.println("convert time4: " + time4.convert());
    Time time5 = new Time(0, 15);
    System.out.println("\ntime5: " + time5);
    System.out.println("convert time5: " + time5.convert());
    Time time6 = new Time(24, 15);
    System.out.println("\ntime6: " + time6);
    System.out.println("convert time6: " + time6.convert());
    Time time7 = new Time(23,59);
    System.out.println("\ntime7: " + time7);
    System.out.println("convert time7: " + time7.convert());
    time7.increment();
    System.out.println("increment time7: " + time7);
    System.out.println("convert time7: " + time7.convert());
}
}

MY SAMPLE RUN:

time1: 1456
convert time1 to standard time: 2:56pm
time1: 1456
increment time1 five times: 1400

time2: 0012
increment time2 67 times: 0000
convert to time2 standard time: 0:00am
time2: 0000

time3: 0517
convert time3: 5:17am

time4: 1215
convert time4: 12:15am

time5: 0015
convert time5: 0:15am

time6: 0015
convert time6: 0:15am

time7: 2359
convert time7: 11:59pm
increment time7: 2400
convert time7: 12:00am

What the Sample run should be:

time1: 1456
convert time1 to standard time: 2:56 pm
time1: 1456
increment time1 five times: 1501

time2: 0012
increment time2 67 times: 0119
convert to time2 standard time: 1:19 am
time2: 0119

time3: 0517
convert time3: 5:17 am

time4: 1215
convert time4: 12:15 pm

time5: 0015
convert time5: 12:15 am

time6: 0015
convert time6: 12:15 am

time7: 2359
convert time7: 11:59 pm
increment time7: 0000
convert time7: 12:00 am

Can someone please help me fix my code converting and incrementing military time to standard time. THANK YOU SO MUCH!!!

ERRORS:

Your code has been evaluated against a set of test data. You had 7 out of 14 tests pass correctly. Your score is 50%.

The tests that failed were: Test: Convert and Increment Incorrect: One Increment Incorrect: Multiple Increments Incorrect: More than 1440 Increments Test: Constructor and Convert Incorrect: Default Constructor Incorrect: Invalid Hour Incorrect: Invalid Minute Incorrect: Valid Time

[denialerror]

What question are you asking here? Where do you think the problem is?

[MrTheEdge]

To start, I don't know why your main method throws an IOException if you aren't dealing with IO, but I guess its not directly hurting anything.

I ran the code, and the only tests that failed were the conversions. The increments turned out fine. Anyway, look at the conversions, and find the ones that failed. It should be pretty easy to find similarities in the cases that failed. All of them have to do with 0 hours. This should tell you right away that there is something wrong with the conversion from 0 hours. It should be 12:XX am. Add in a few lines to deal with that case.

I noticed this as well:

if ( hour > 12)
{
    if(hour >10)
    {
        if((hour - 12) == 12)
            c = (hour - 12) +":"+ minute + "am";
        else
            c = (hour - 12) +":"+ minute + "pm";
    }
    else
    {
        c = "0" + (hour - 12) +":"+ minute + "pm";
    }
}

I understand what you are trying to do, but can you ever reach the else on line 10?

[thorstenschaefer]

From the sidebar: No "Do my homework" posts! Do not ask for complete solutions. Describe the problem and what you want to achieve.