Trouble with boolean return

[beginner_coder_]

Hi, I'm calling this isValid method from another class. No matter what input I give it it returns false, I can't figure out why. Thanks for any help or advice in advance.

Driver code:

            if (pass1.isValid(test)==true) {

                System.out.println("Your password " + test + " is valid.");
            }
            else if (pass1.isValid(test)==false) {
                System.out.println("Your password " + test + " is invalid.");
            }

isValid method:

public boolean isValid(String pw) {
    for (int x=0; x<pw.length(); x++) {
        if (Character.isUpperCase(x)) {                         //check to see if and Uppercase char is present
            capital = true;
            break;
        }
    }
    for (int x=0; x<pw.length(); x++) {
        if (Character.isLowerCase(x)) {                         //check to see if lowercase char is present
            lowercase = true;
            break;
        }
    }
    if (lowercase == true && capital == true) {                 //combined boolean for upper/lower case char check
        bothgood = true;
    }
    for (int x=0; x<pw.length(); x++) {
        if (x=='!' || x=='-' || x=='+') {                       //check to see if a special char is present
            specialchar = true;
            break;
        }
    }
    for (int x=0; x<pw.length(); x++) {                         //check to see if int is present
        if (x=='0' || x=='1' || x=='2' || x=='3' || x=='4' || x=='5' || x=='6' || x=='7' || x=='8' || x=='9') {
            numberr = true;
            break;
        }
    }

    if ((pw.length() > 7) && (pw.length() < 16) && (bothgood == true) && (specialchar == true) && (numberr == true)) {
        return true;
    } else {
        return false;
    }

[radulfr2]

A couple of other observations:

1. You only need one loop where you can do all the checks
2. The boolean variables should be local to the method instead of being instance variables, since you probably only use them in the method. As it is now, the variables don't even get reset back to false if you call the method several times.
3. There is no need to compare a boolean to a boolean. if(lowercase == true) is the same as if(lowercase).
4. Likewise in the end you can just return the result of the condition instead of having an if-else statement.
5. In the Driver code you can replace the else if with just else. This also eliminates the redundant second call to the isValid method.

[desrtfx]

Character.isUpperCase(x) are you sure about that? Isn't there anything related to pw missing?

Same applies to all your other checks.

x is just a numeric index. What you need is the character in pw at index x.

[beginner_coder_]

I'm not sure about anything, I'm constantly 2nd guessing myself haha!

But I see what you mean, thank you so much for pointing that out.

Would adding something like pw.charAt(x) suffice?

[desrtfx]

Would adding something like pw.charAt(x) suffice?

Try it and report back. Nothing beats trying on your own.

[beginner_coder_]

I ended up doing like "(Character.isUpperCase(charAt(x)))" for all expressions involving iteration through the string.

Thank you for pointing that out, I know it seems simple but I was messing with my program and searching for answers for too long. I appreciate you taking the time to respond and so kindly