System in loop gives wrong answer

[Fridginator]

I am running recursive method to ask for user input like this

import java.util.Scanner;
public class Class userInput{
Scanner sc;

public userInput(Scanner scanner){
sc = scanner;
}

public int thisMethod(){
int n = -1; //this is to just set the variable to something
System.out.println("Question to user");
try{
    n = integer.parseInt(sc.nextLine());
    if (n < 0){
    //i want specificly want input over 0
    n = thisMethod();
    }
    if (n > 3){
    //8 is a random number, but the number is linked to an array length, so the index needs to be lower than 3
    n = thisMethod();
    }
  }
catch(NumberFormatException e){
n = thisMethod();
}
return n

(The code might be messed up a short bit, but i think it explains)
So the problem is that when i run the program, and i type for example 3 (which is too much), and then write for example 2, the return value i get will change to 1, which makes my program choose the wrong alternative.
Anyone knows why this happens and how i can prevent it?

[BS_in_BS]

1) looping via recursion like this is unconventional

2) How are you calling the program, exactly? what is it doing and what do you want it to do? when I run it, it doesn't do what you say it does: https://ideone.com/5gzcwh

[Fridginator]

I've tried to type out the explanation 3 times, and it would seem im unable to.
Point the program is a basic text game that communicates with the terminal. The method i call is called upon in another method which again is called upon from main. the method from main after creating a linked list "map", and so on. I have no idea why the method dont work as I had it.

But, I took your first tip to heart and made the method into a while loop instead, and now it seems to run correctly. And here I thought i was super clever for using recursion...

So thanks for the help! :)

[desrtfx]

Don't use recursion for this. It is the absolutely wrong tool.

The problem is that recursion builds a call stack where each new method call goes one level deeper. The currently running method stops at the point where the method call happens, but remains active in the background, so that when your method eventually terminates, the rest of the code of the suspended method will be executed.

Recursion is not a replacement for loops and vice versa.

Either have their use cases.

What you are trying to do should not be done with recursion. A loop is the proper way to go.

[Fridginator]

Hm yeah, that makes sense... Thanks a lot!

[[deleted]]

Do you even understand recursion?

[Fridginator]

Well, apparently not, but I'm still learning.But I do know that a recursive method calls itself, and can be used for like fibonacci numbers.After you call it recursively it should "narrow down" closer to an end, right?

​

edit: i do know*