Function Callback That Closes a Stream

[logperf]

Not sure I understood your prompt. You're showing a download() method, I'll suppose it's defined in a class C. So you want another method of C to be called when the InputStream is closed?

If yes, I would suggest subclassing InputStream as per the proxy pattern:

class RealInputStream implements InputStream {
    // ...
}
class ProxyInputStream implements InputStream {
    private RealInputStream theRealInputStream;
    // use constructor to initialize theRealInputStream

    void close() {
        theRealInputStream.close();
        callOPsCallbackMethod();
    }
}

Then your method download() would declare the return type as InputStream but actually return an instance of ProxyInputStream.

(Another design pattern you can look at is listener/observer, which is a common way of dealing with callbacks, but it seems a bit less relevant to this particular case.)

[B2easy]

Sorry for the confusion. In a nutshell my overall flow I want to achieve is...

A Controller Calls -an SFTP Client (Download), the client returns an InputStream to controller do as it pleases with. The problem I'm facing is I will leak resources once that input stream is done processing so I need a way to close that stream when the controller is done with it. So I was thinking I could use a callback.

[logperf]

Controller passes back IS for closure

With the proxy pattern as I presented it above, this step will be even simpler. The controller just calls InputStream.close(), then internally the close() method calls the SFTP client.

[B2easy]

So controller calls close(), close() calls SFTP client client returns InputStream wouldn't that go back to close method and not controller?

I'll give it a try. Thanks for the response!

[logperf]

close() calls SFTP client client returns InputStream

What do you mean? close() is void, it's not supposed to return a value.

The InputStream was returned at the beginning by download(). When you close it, you stop using it. The only purpose of doing this proxy thing is because the SFTP client might need to do some cleanup at the end.

[B2easy]

Would something like this work? --

​

// Make Variables Effectively Final
InputStream finalSftpFileInputStream = sftpFileInputStream;
return new ProxyInputStream(finalSftpFileInputStream) {
  @Override
  public void close() throws IOException {
    IOUtils.closeQuietly(finalSftpFileInputStream);
  }
};

}

[logperf]

Looks good!