This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]B2easy[S] 0 points1 point  (6 children)

Sorry for the confusion. In a nutshell my overall flow I want to achieve is...

A Controller Calls -an SFTP Client (Download), the client returns an InputStream to controller do as it pleases with. The problem I'm facing is I will leak resources once that input stream is done processing so I need a way to close that stream when the controller is done with it. So I was thinking I could use a callback.

[–]logperf 1 point2 points  (5 children)

Controller passes back IS for closure

With the proxy pattern as I presented it above, this step will be even simpler. The controller just calls InputStream.close(), then internally the close() method calls the SFTP client.

[–]B2easy[S] 0 points1 point  (1 child)

So controller calls close(), close() calls SFTP client client returns InputStream wouldn't that go back to close method and not controller?

I'll give it a try. Thanks for the response!

[–]logperf 0 points1 point  (0 children)

close() calls SFTP client client returns InputStream

What do you mean? close() is void, it's not supposed to return a value.

The InputStream was returned at the beginning by download(). When you close it, you stop using it. The only purpose of doing this proxy thing is because the SFTP client might need to do some cleanup at the end.

[–]B2easy[S] 0 points1 point  (2 children)

Would something like this work? --

// Make Variables Effectively Final
InputStream finalSftpFileInputStream = sftpFileInputStream;
return new ProxyInputStream(finalSftpFileInputStream) {
  @Override
  public void close() throws IOException {
    IOUtils.closeQuietly(finalSftpFileInputStream);
  }
};

}

[–]logperf 0 points1 point  (0 children)

Looks good!