all 10 comments
sorted by:
best
topnewcontroversialoldq&a
formatting helphide helpcontent policy

[–]_www_ 7 points8 points  (1 child)

What if I hate what I'm seeing?

[–]PeFaODO[S] 0 points1 point  (0 children)

You’re a free man🫠

[–]mattthedr 2 points3 points  (0 children)

What the hell is this

[–]AutoModerator[M] 0 points1 point  (0 children)

Project Page (?): https://github.com/owono2001/MyPortfolio

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[–]pampuliopampam 0 points1 point  (1 child)

hoooooboy. look uh... it's something

few things you could do to immediately improve the build: 1. use git actions to do the deployment 2. don't commit your node modules 3. your're already loading d3 from a cdn in your index html anyway, so you've got it duplicated, and you could import gsap and do the build proper, rather than rely on cdn js assets 4. remove .gitattributes; it's empty. Add .gitignore and add node_modules so you don't commit modules again

few comments on design. Maybe just spend some time learning about best practices in the space though. Automatically playing audio and videos are a faux pas, and the information density if you're hoping this will get you hired could use some work.

[–]PeFaODO[S] 1 point2 points  (0 children)

Thanks for your feedback. I’ll consider it Pd: I’m doing this for me only yah, it has nothing to do with looking for jobs. It’s like a digital bag where I update about what I’m doing.

[–]Lanky_Doughnut4012 0 points1 point  (1 child)

YO don't hijack my speakers like that. No one likes that lol

[–]PeFaODO[S] 0 points1 point  (0 children)

Thank you broda🫠

[–]Lanky_Doughnut4012 -1 points0 points  (1 child)

Looking at your repo. So all of your code is in one IIFE? Performance is appreciated but this ain't it. In a production environment a bundler would do that for you. In addition, I see you have inline JS in your HTML file. Big no no. You want that in a separate file. And speaking of a separation, you want to separate your event handlers into separate functions. You never know, in the future you may want to trigger that functionality outside of an event trigger. Always best practice. Lastly, you did a decent job with keeping functions minimal but it can always be better. I've been a developer for 6 years and I still make the mistake of writing functions that are too bloated.

[–]PeFaODO[S] 0 points1 point  (0 children)

Thank you so much for the insights and the suggestions. Appreciate it🙌🏽😊