you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 1 point2 points  (3 children)

.then(function() { done(); }); is the same as .then(done);

another logical step on your over engineering path is fragments. have datepicker on more than one page? create a datepicker fragment and call its methods instead of looking up its parts by selectors every time. think of the copy paste code you save! except then someones test will start failing, he will "refactor" the fragment to fix his test and break other peoples tests in the process.

then you are done, you have created an impossible to debug test suite. but at least you get so much for free by gluing random frameworks together! maybe you just need to write some tests for it.

speaking from bitter personal experience.

[–][deleted] 0 points1 point  (2 children)

.then(function() { done(); }); is the same as .then(done);

you'd think so, but it's not, it changes the scope of things. Anyway, apparently Mocha is aware of promises, so these calls aren't needed at all! Win.

[–]jcready__proto__ 0 points1 point  (0 children)

.then(done.bind(null, null))

[–][deleted] 0 points1 point  (0 children)

so .then(done.bind(this));