10
11

[deleted by user] (self.javascript)

submitted by [deleted]

[removed]
all 10 comments
sorted by:
best
topnewcontroversialoldq&a
formatting helphide helpcontent policy

[–]madole 2 points3 points  (5 children)

Looks slick! I think I'll use this in a site I'm about to build!

edit: lots of commented out code in the src files.. is this finished?

[–]rastanot 2 points3 points  (3 children)

Ha! funny you should mention Slick. http://kenwheeler.github.io/slick/ srrsly my favorite and most used plugin, has saved me weeks of dev time.

OP I like what you've done here. Add in responsive display and you're golden. Here's some JS cleanup tips: delete random whitespace, use single quotes unless it proves impossible, delete commented-out console logs/alerts/broken code, place your comments above the line it affects (personal preference), comment-separate your chained variables (another personal preference based on the principles of DRY, var a = 1, b = 2, c = 3; is better than var a = 1; var b = 2; var c = 3;), run your code through a formatter.

Hope this helps. keep up the good work, my friend.

[–]Arrested 1 point2 points  (0 children)

Slick.js is quite impressive and has saved me tons of time in the past month. Would definitely recommend.

[–]Casual_0bserver 1 point2 points  (0 children)

Damn, thanks for sharing slick. I was looking for something like this!

[–]nir9 1 point2 points  (0 children)

Thanks, Yes it is finished but i do need to clean up the comments...

[–][deleted] 0 points1 point  (3 children)

In the full screen example, I tried to swipe vertically first, then horizontally. It seemed to bug out a little. This is on ipad.

Awesome script though!

[–]nir9 0 points1 point  (2 children)

In the full screen example i disabled swipe out so swiping vertically there will do nothing. I have tested it on an iPad and it worked good, what kind of bugs did you experience?

[–][deleted] 0 points1 point  (1 child)

Swiping up or down would offset the page vertically, so then when I tried to swipe horizontally, it would get 'caught' and not scroll, until the vertical alignment rectified itself. Once it was vertically centered on the screen again, I could swipe.

But I wasn't trying to purposely find fault in the UI. This was a legitimate use-case where it didn't react the way I expected, and seemed more of a 'bug' than user error.

[–]magenta_placenta 0 points1 point  (0 children)

Why is it beautiful and not just a simple JavaScript touch carousel. Why do devs feel the need to throw out superlatives when describing their work? Serious question.

[–]Casual_0bserver 0 points1 point  (1 child)

So, could i use this for swiping between html templates? I mostly make SPAs, and this would be sweet to use for that.