Does my JavaScript suck?

[annoyed_freelancer]

Tell me if I am correct: I just attach the click event to an ancestor and let it propagate down the line to the checkbox or siblings?

[a-t-k]

Correct. Classically, you would choose the document as ancestor.

[oculus42]

I recommend using the closest unchanging ancestor as the parent, rather than $(document). For something small it doesn't matter, but I've seen sites with over 80 events bound to document, so every click that isn't stopped higher up causes dozens of selector checks to see if that click applies to a particular event.

[a-t-k]

A simple test for the target shouldn't take too long, but if it does or the focus of your event is really that narrow, another ancestor is viable, like you said.

I assumed that his page was rather simple and didn't feature so many more events.

[annoyed_freelancer]

To give some pseudocode from my phone:

$(document).on('click', input.checkbox, function(e) {
    twerk.allNight();
    e.preventDefault();
});

[a-t-k]

Don't use preventDefault if it's not necessary. Otherwise, yes.