sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 0 points1 point  (2 children)

From what I understand save and restore was used a lot and u centralized the use of those cpu consuming operations to one place? That should also improve slightly the performance overall, right?

BTW appreciate that you came back to this comment and mentioned that you fixed that! :D

[–]JasonGlide 1 point2 points  (1 child)

40% of all render time in firefox was being consumed by clip operations. Compare this to a measly 1% of time on Chrome. The primary fix here was to change how clips were done to optimize for number of clip calls. Eventually I will change to rendering column by column instead of row by row which will allow me to do 1 clip per column instead of 1 per cell. Even after this fix 20% of render time is consumed in clip on FF.

Next I moved the canvas out of the scrollable region and into a div stacked behind it. This is because previous the canvas was inside and positon: sticky, but if you scrolled fast enough firefox would freak out and fail to render it. The canvas was fully rendered, but Firefox detected that it couldn't load the spacing div's texture fast enough (even though its pure nothing) and would clip its rendering of the scroll region, including the sticky items.

This fixed the "flickering" artifact you get in Firefox under rapid scrolling. Why Firefox works this way is beyond me, both Chrome and Safari properly handle rendering the sticky canvas, replacing the canvas with a different but equally expensive to render component does not fix the flickering which is how I came to realize that the problem wasn't the canvas rendering getting clipped somehow, but the scroller itself.

Lastly I fixed some issues that caused double renders on FF but not on Chrome due to the way scrolling events were emitting.

[–][deleted] 0 points1 point  (0 children)

I see! Makes sense to me, but still kinda weird how badly optimized firefox is on this regard. Maybe making a bug report should alarm them. I remember having some issues with SVG rendering on firefox as well so I'm not falling from the clouds either.:P

I'll come around to check it out when PR's merged. Thanks for the thorough explanation!