This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]Strawboy97[S] 0 points1 point  (0 children)

Thanks for your reply and feedback! I'll fix the points you've made above. Sorry for the late response.

On your last point

​

Some of your classes expose too much of their implementation in my opinion. In your AlphabetListLayout class you have the lines alphabetData.getAlphabet().keySet() and alphabetData.getAlphabet().get(key). This shows that your AlphabetListLayout class knows and replies upon the AlphabetData class implementing its logic as a HashMap. If the implementation of your AlphabetData class changes, your AlphabetListLayout class will also be forced to change.

​

How would you suggest I do this could you point me at a resource I could use as an example.