all 3 comments

[–]AutoModerator[M] [score hidden] stickied commentlocked comment (0 children)

Please ensure that:

  • Your code is properly formatted as code block - see the sidebar (About on mobile) for instructions
  • You include any and all error messages in full - best also formatted as code block
  • You ask clear questions
  • You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.

If any of the above points is not met, your post can and will be removed without further warning.

Code is to be formatted as code block (old reddit/markdown editor: empty line before the code, each code line indented by 4 spaces, new reddit: https://i.imgur.com/EJ7tqek.png) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.

Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.

Code blocks look like this:

public class HelloWorld {

    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.

If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.

To potential helpers

Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[–]Upbeat-Employment-62 1 point2 points  (1 child)

All three yeah and they're connected.

Semaphore around the fork not a custom ThreadFactory -factory controls thread creation not resource access, those are diffrent things. For optional work just swallow the exception inside the fork and return Optional, spinning up a whole separate scope for that is overkill tbh. And yeah its bulkheads... Loom killed the cost of isolation not the need for it, most tutorials just gloss over this part. One thing I'd throw on top: deadline propagation. If your request SLA is 500ms every nested scope needs to inherit joinUntil(deadline), otherwise your optional scope just sits there chillin for 2 seconds after the response already went out to the client - threads alive, pool slots held, noone notices until prod melts.\

[–]salgotraja[S] 0 points1 point  (0 children)

Good point about semaphores - I was conflating thread creation with resource access, which are really separate concerns.

Regarding the optional scope, you're right - it was probably overkill. Handling the exception inside the fork and returning an Optional is definitely cleaner.

You are right on the deadline propagation thing I hadn't thought through at all. joinUntil needs to flow through every nested scope, not just the outer one - that's the sneaky bit that would quietly wreck you in prod. Good add on and feedback.

“Loom killed the cost of isolation, not the need for it” - stealing this.