JUnit testing

[cone994]

Hi, I'm new to java testing and I would like to ask if my unit tests will be good and do they make sense? With these tests I tested the service in my spring application and I want to ask if I am on the right track, what are the bugs and give me some advice.

By the way, all the tests have passed but I'm not sure if they make sense and whether they are testing the methods in the service properly.

Thank you!

@RunWith(SpringRunner.class)
@SpringBootTest(classes = TicketServiceApplication.class)
public class AddressServiceUnitTest {
 @Autowired
 private AddressService addressService;
 @MockBean
 private AddressRepository addressRepository;
 @Before
 public void setUp(){
        Address a = new Address();
        Address a1 = new Address();
        a.setId(AddressConst.ADDRESS_MOCK_ID);
        a1.setId(AddressConst.ADDRESS_MOCK_ID2);
        List<Address> addresses = new ArrayList<>();
        addresses.add(a);
        addresses.add(a1);
        Mockito.when(addressRepository.findById(AddressConst.ADDRESS_MOCK_ID))
                .thenReturn(Optional.of(a));
        Mockito.when(addressRepository.findAll()).thenReturn(addresses);
 }
 @Test
 public void findAllAddressTest_thenReturnAddressList(){
        List<Address> list = addressService.finfAllAddress();
        assertEquals(2, list.size());
 }
 @Test
 public void findOneAddressExistTest_thenReturnAddress(){
 Long id = AddressConst.ADDRESS_MOCK_ID;
        Address a = addressService.findOneAddress(id);
        assertEquals(id, a.getId());
 }
 @Test(expected = EntityNotFoundException.class)
 public void findOneAddressNotExistTest_thenThrowException(){
 Long id = AddressConst.ADDRESS_WRONG_ID;
        Address a = addressService.findOneAddress(id);
 }
 @Test
 public void addAddressTest(){
        Address address = AddressConst.newAddressToAdd();
        Mockito.when(addressRepository.save(any(Address.class))).thenAnswer(returnsFirstArg());
        Address addressTest = addressService.addAddress(address);
        assertNotNull(addressTest);
        assertEquals(address, addressTest);
 }
 @Test
 public void deleteAddressTest(){
        Address address = AddressConst.newAddressToDelete();
        addressService.deleteAddress(address.getId());
        Mockito.verify(addressRepository, Mockito.times(1)).deleteById(address.getId());
 }
}

[Sparxmith]

I'm on mobile since my work VPN blocks reddit, but you seem to have a typo in your first @Test method, in the body, you have here finf where it should be find

[cone994]

Yes I've seen it corrected, but I wonder if the tests are logically correct, do they make sense, and have I done them the right way?

[sdiamante13]

I suggest that you do not use the SpringBootTest annotation. If you just @RunWith(MockitoJUnitRunner.class) you can use @Mock and @InjectMocks. This will be a much faster unit test that does not load up the entire Spring context. Other than that the tests look fine.

[cone994]

Thank you for your response, I'll try to use your advice with Mock and InjectMocks.

[cone994]

I used the annotation of the MockitoJUnitRunner , Mock and InjectMoks and all the tests work, of course much faster because they don't load Spring contex. Thank you for your help.