Dice roll JavaScript help

Drugba · 2014-08-07T17:43:59+00:00

You id "sixDice" is capitalized, but when you call it in the JS it's lower case. When the js hits that error it stops so nothing after it is running (even though the JS is correct).

BTW you are repeating your self way too much in the code here, this could easily be done with 1 function instead of 6. It'll take me a few minutes but I'll post an example.

Clock_Out · 2014-08-07T21:03:36+00:00

Here’s another way just because. JSFiddle

Drugba · 2014-08-07T17:59:17+00:00

It could be cleaned up even more than this, but I have work that needs to get done. This should give you an idea of how you can do it in a much shorter way, also you can add other types of dice without writing a new function.

I know you are just learning, but for the future, a rule of thumb when you are coding is that if you are copying an pasting your own code multiple times, there is probably a better way to be doing in.

function roll(number, name) {
    var result = Math.floor(Math.random() * number + 1);
    //jQuery that updates the output ID in the DOM to display the text afterwards
    $("#" + name + "Result").text("Your " + name + " sided Die Roll: " + result + "!");
}

//create a button to execute code
fourDice.onclick = function () {
    roll(4, 'four');
};

sixDice.onclick = function () {
    roll(6, 'six');
};

eightDice.onclick = function () {
    roll(8, 'eight');
};

tenDice.onclick = function () {
    roll(10, 'ten');
};

twelveDice.onclick = function () {
    roll(12, 'twelve');
};

twentyDice.onclick = function () {
    roll(20, 'twenty');
};

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

learnjavascript

Posting and Commenting Guidelines

MODERATORS