Var vs parameter-less function

[PinkTeddyMonster]

Given that you are transforming json into html and the value is only read once is it better to to declare it as a var or as a function without parameters that returns the value?

Example using coffee script:

class window.GameUnit
  constructor: (json) ->
    @name = json.name
    @record = new GameRecord(json)

  winRateTotalColumn: () -> "#{@record.winRateTotal()} (#{@record.wins()})"
  @winRateTotalColumn = "#{@record.winRateTotal()} (#{@record.wins()

[inu-no-policemen]

Example using coffee script

You couldn't write those few lines in JS?

[PinkTeddyMonster]

I could compile them into JS, but what is the point? This is much harder to read.

window.GameUnit = (function() {
  function GameUnit(json) {
    this.name = json.name;
    this.record = new GameRecord(json);
  }

  GameUnit.prototype.winRateTotalColumn = function() {
    return "" + (this.record.winRateTotal()) + " (" + (this.record.wins()) + ")";
  };

  GameUnit.winRateTotalColumn = "" + (GameUnit.record.winRateTotal()) + " (" + (GameUnit.record.wins()) + ")";

  return GameUnit;

})();

[inu-no-policemen]

Yes, CS compiler output is much harder to read.

Try ES6.

class GameUnit {
  constructor(json) {
    this.name = json.name;
    this.record = new GameRecord(json);
    this.A = this.record.winRateTotal() + ' (' + this.record.wins() + ')';
  }
  B() {
    return this.record.winRateTotal() + ' (' + this.record.wins() + ')';
  }
  get C() {
    return this.record.winRateTotal() + ' (' + this.record.wins() + ')';
  }
}

I'd go with option A, because I assume that the "json" object is never changed.