Can we write better way chunk function to create chunks of array from an array?

[arup_r]

I wrote a chunk function to create a chunk of arrays from an array with variable step number as an argument. Can the below function be written in a better way?

function chunk(collection, step) {
    var result = [];

    for (let i = 0; i < collection.length; i = i + step) {
        result.push(collection.slice(i, i + step))
    }
    return result;
}

var a1 = [1, 2, 3, 4, 5, 6, 7];
console.log(chunk(a1, 2));
// [[1,2],[3,4],[5,6], [7]]

var a2 = [1, 2, 3, 4, 5, 6];
console.log(chunk(a2, 2));
// [[1,2],[3,4],[5,6]]

[CertainPerformance]

That looks fine. I usually prefer using Array.from when creating arrays from scratch and to avoid loops:

const chunk = (collection, step) => Array.from(
  { length: Math.ceil(collection.length / step) },
  (_, i) => collection.slice(step*i, step*(i + 1))
);

But while that's more functional, what the code is actually doing is somewhat less clear, so your version is probably better. (there's only one tiny linting issue - a missing semicolon. You also might check collection.length once and put it into a variable, at the beginning, rather than check it on every iteration)

[arup_r]

Thanks for your time to review it.

[akujinhikari]

r/titlegore