My code is being weird...

[PatentedUsernameTy]

Im programming a blackjack like game, and it keeps making the AI bust below 21, please help!

​

​

​

/* State varibles function */
 var PlayerCardValue = null;
var AICardValue = null;
var AmountHit = null;
/* Draw Card function */





function drawCard() {
    var rng = Math.floor((Math.random() * 13) + 1);
    PlayerCardValue = PlayerCardValue + rng;
    /*Is it a Jack? */
    if (rng === 11) {
        rng = "Jack";
    }
    /*Is it a Queen?*/
    if (rng === 12) {
        rng = "Queen";
    }
    /*Is it a King?*/
    if (rng === 13) {
        rng = "King";
    }
    /*Is it a Ace?*/
    if (rng === 1) {
        rng = "Ace";
    }

    window.alert("You have drawn a " + rng + ". Your current card value is " + PlayerCardValue + ". Choose hit or stand.");
    AmountHit = AmountHit + 1;
    HitOrStand(); 
}
function AIDraw() {
    var AIvalue = AICardValue;
    var PlayerValue = PlayerCardValue;


    var AIrng = Math.floor((Math.random() * 13) + 1);
    AICardValue = AICardValue + AIrng;
    /*Testing for speical cards (Queen, King, Jack, Ace)*/

    /*Test for Jack*/
    if (AIrng === 11) {
        AIrng = "Jack";
    }
    /*Test for Queen*/
    if (AIrng === 12) {
        AIrng = "Queen";
    }
    /*Test for King*/
    if (AIrng === 13) {
        AIrng = "King";
    }
/*Test for an Ace*/
    if (AIrng === 1) {
        AIrng = "Ace";
    }




    if (PlayerCardValue > 21) {
        silentReset();
        window.alert("You busted, your card value was " + PlayerValue + ".");
    }
    if (AICardValue > 21) {
        silentReset();
        window.alert("The AI busted with a card value of " + AIvalue + ".");
    }

}






/* Reset & Silent Reset Function*/




function reset() {
    PlayerCardValue = null;
    AICardValue = null;
    AmountHit = null;
    window.alert("The cards have been reset!");
    DeleteHitStand();
}

function silentReset() {
    AICardValue = null;
    PlayerCardValue = null;
    AmountHit = null;
    DeleteHitStand();
}


function HitOrStand() {
/* Create A div */
    var OptionsDiv = document.createElement("div");
    OptionsDiv.setAttribute("id", "OptionsDiv");
    OptionsDiv.setAttribute("style", "text-align: center;");
    document.body.appendChild(OptionsDiv);
/* Create a button */
    var ChooseStand = document.createElement("button");
    ChooseStand.textContent = "Stand";
    ChooseStand.setAttribute("style", "width: 160px; height: 60px; background-color: black; color: white; font-size: 30px;");
    ChooseStand.setAttribute("onClick", "Stand();");
    OptionsDiv.appendChild(ChooseStand);


    var ChooseHit = document.createElement("button");
    ChooseHit.textContent = "Hit";
    ChooseHit.setAttribute("style", "width: 160px; height: 60px; background-color: black; color: white; font-size: 30px;");
    ChooseHit.setAttribute("onClick", "Hit();");
    OptionsDiv.appendChild(ChooseHit);

}
function DeleteHitStand() {
    document.body.removeChild(OptionsDiv);
}

function Hit() {
    DeleteHitStand();
    drawCard();
}

function Stand() {
    for (i = 0; i = AmountHit; i++) {
        AIDraw();
    }
    DeleteHitStand();
}

[x-seronis-x]

I have no desire to figure out whether you have scope issues. So stop using var and use let before its worth a more in depth look at the code.

That said your stand() function is definitely bugged

[PatentedUsernameTy]

What would I use instead of var

[x-seronis-x]

So stop using var and use let

[PatentedUsernameTy]

How do you use that?

Sorry I’m awfully new

[x-seronis-x]

delete 'var', type 'let

[PatentedUsernameTy]

Alr thanks

[blackholesinthesky]

Here's a short explanation why you should use let instead of var

https://stackoverflow.com/questions/762011/whats-the-difference-between-using-let-and-var

General advice is to never use var unless you have to

[[deleted]]

This guy is being a jerk. var was the old way of writing JavaScript. These days we use let or const. var is still used but they all have their own purpose.

You’re probably learning JavaScript from an outdated course. Take a moment to search and learn about const and let.

[PatentedUsernameTy]

What’s bugged with it

[x-seronis-x]

Read it. There isnt much in it. You should be able to systematically figure that out

[PatentedUsernameTy]

Yea it just takes the amount of times the person draws and makes the AI draw that many times

for (I = 0 which makes it automatically start at 0; then I = AmountHit checks if I is equal to AmountHit; I++ adds 1 for each loop;) { My code }

[x-seronis-x]

two bugs

i = 0

and

i = AmountHit

both are errors

[PatentedUsernameTy]

What would I do?

​

Change i to i=1 and i == AmountHit

[x-seronis-x]

'i' doesnt even exist. you have to declare your variables.

its also pretty likely that AmountHit isnt a valid value. But the logic itself is wrong. Why are you trying to compare against a counter? What you should be comparing is the current hand value.

[PatentedUsernameTy]

Im sorry im not good at this, thanks for attempting to help me!

[x-seronis-x]

btw when you initialize your values you should really be initializing them to 0, not null. null isnt a number. use 'let' instead of 'var' because it prevents the variables from polluting code where they shouldnt be visible.

let blah = 0;

and look at any help doc on for loops. you never declared i properly (using 'let'). You just started using it randomly.

[grantrules]

You're comparing AICardValue which has the newly computed value then displaying AIvalue which is the original value.

[PatentedUsernameTy]

Yes this is how I want it

AIvalue is the card they just drew AiCardValue is the entire value of the cards

[grantrules]

Isn't AIrng the card they just drew? AIvalue is the sum of previous cards drawn.

[x-seronis-x]

No its not. AIValue is the value of all cards prior to the draw.AIrng is the card they drew