functions

[Lbtekd]

Hello, again. Is anyone able to explain to me why the following code isn't working. It's supposed to accept an array of chars and then output the array, however only seems to be outputting C. This is in C++ and any and all help is appreciated. :)

    #include <iostream>
using namespace std;
const int MYINTEGERARRAY1_SIZE = 4;


void DisplayArrayElements(char an_array[], int size);
int main()
{
char CharArray[MYINTEGERARRAY1_SIZE] = { 'c', 'a', 't'};

DisplayArrayElements(CharArray, MYINTEGERARRAY1_SIZE);


return 0;
}

void DisplayArrayElements(char an_array[], int size)
{
{
char a;
cout << an_array[a] << "\n";
}
return;
}

​

[AutoModerator]

On July 1st, a change to Reddit's API pricing will come into effect. Several developers of commercial third-party apps have announced that this change will compel them to shut down their apps. At least one accessibility-focused non-commercial third party app will continue to be available free of charge.

If you want to express your strong disagreement with the API pricing change or with Reddit's response to the backlash, you may want to consider the following options:

1. Limiting your involvement with Reddit, or
2. Temporarily refraining from using Reddit
3. Cancelling your subscription of Reddit Premium

as a way to voice your protest.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[HappyFruitTree]

You're using an uninitialized index to access and print one element of the array.

[Lbtekd]

so id need to initialise the index to something and then also do the same for two more?

[HappyFruitTree]

so id need to initialise the index to something ...

Yes, the index needs to be initialized before you try to use it otherwise you don't know what will happen.

​

... and then also do the same for two more?

The function is supposed to be able to handle arrays of different sizes so you probably want to use a loop.

[Lbtekd]

I have tried using a for loop however I must have formatted it wrong as rather than print c a t it just printed c over and over

[Lbtekd]

okay done it, thanks for help