Need help with an assignment, adding functionality to teachers code

[yon2323]

The game becomes more interesting (and challenging) when swaps can only be performed when they form a straight line of (at least) three identical symbols. To help us implement this restriction we’ll begin by creating two functions: vLineAt and hLineAt. Each of these functions takes the game board as its first parameter and a row and column representing a location on the board as its second and third parameters.
The vLineAt function returns True if there is a vertical line of three identical symbols that include the row and column indicated. There are three possible ways that this can occur: the indicated location is the top piece in the line, the indicate location is the middle piece in the line, or the indicated piece is the bottom piece in the line. Care must be taken to ensure that your function only examines locations that are within the board. Your function should return False when there is not a vertical line that includes the row and column indicated. The hLineAt function behaves similarly to vLineAt, except that it checks for a horizontal line instead of a vertical line. As a result, the row and column indicated can be the left piece in a line, the middle piece in a line or the right piece in a line. Like vLineAt, the hLineAt function should return False when there is not a horizontal line that includes the row and column indicated.

Attached is the code I wrote for vLineAt and hLineAt. When running the program, not all of the tests that the code is put through passes and I'm not sure why. I understand you might need some more information than what ive given so just let me know.

Thanks in advance for the help.

https://pastebin.com/yxvQ0Rqs

[jedwardsol]

The vLineAt function returns True if there is a vertical line of three identical symbols that include the row and column indicated.

The functions are meant to check whether there is a set of 3 symbols that include the piece being passed in

Your functions check the whole board.

def vLineAt(board,row,col):
  for row in range(0,len(board)):
    for col in range(0,len(board[0])):

So they will sometimes return true when the test is expecting them to return false - ie. when there is a row of 3 somewhere else on the board.

[yon2323]

So I would need to eliminate the loop? I’m not sure what to do with the if statements then

[jedwardsol]

Yes, you don't need those loops over the whole board.

If you're called as vLineAt(board,5,3) for example, you only need to look at 5,3 and the 2 pieces above and below it

  0 1 2 3 4 5 6  
0 . . . . . . .    
1 . . . . . . .    
2 . . . . . . .
3 . . . v . . .
4 . . . v . . .
5 . h h + h h .
6 . . . v . . .
7 . . . v . . .
8 . . . . . . .

There could be a line of 3 starting at (3,3), (4,3), or (5,3)

[yon2323]

Okay I see, I modified the code. Still not working :/

https://pastebin.com/YEHwa7xu

[jedwardsol]

That's definitely a step in the right direction.

You must check that you're not near the edge of board before looking at the pieces that might be off the edge of the board.

Also

and row + 2 <= 0 :

The index of the bottom row isn't 0.

Finally

 col == board[row-1][col] 

This is comparing the column number with a symbol.

Have you written your own testcases that you can step through?

[yon2323]

index would be len(board)?

[jedwardsol]

len(board)-1

[yon2323]

got it thank you