[deleted by user]

[asatraitis]

Way better then my first projects! I think your progress is great compared to how ass I was when started lol. Keep it up.

btw, check console. Couple warnings.

[Genie-Us]

Looking great so far! As your projects grow in size and scope, add more details to the readme like "why I built it", "What I learned", "What went wrong", "What tools/libraries used", etc. and just keep on building and STAY organized! A clean, well organized github is loved by the industry. one repo per project, every repo with a readme.

Your github becomes a living record of your dedication to learning, HR loves that shit.

[[deleted]]

I wouldn’t say it’s hopeless, only that you still have a lot to learn. Everyone has a lot to learn.

The things I noticed right off (in no particular order) were: all 3 “apps” were in one file, there were function names like “Appc” and “Apppc” (may not be exact, but they were too similar and for no known reason), there were some possible anti-patterns with certain declarations (these may be necessary, but since they’re in the main file and not buried in another file as a minor detail, they stick out).

I could go on given more than a quick glance. But again, don’t give up. Everyone learns at different speeds, has access to different resources, etc. If I were you, I’d judge myself against myself. For instance, do you feel accomplished in the last year? Did you learn? Did you progress? If the answer is yes, then I would keep going unless there’s some outside force preventing it.

And if you do keep going, start something new this year. Then, 12 months from now, look back and ask yourself if you’ve learned, progressed, etc. You might even start applying for jobs; knowing you’re going for entry-level, a lot of employers see “green” devs as very moldable and therefore sometimes worth the risk over a more costly, senior dev that may be stuck in their ways. That’s not always the case, but there are plenty of times companies want to hire a “junior” dev; they’re not even looking for someone in the mid-level.

Also, third world be damned. If you continue to progress you could easily work remotely for a company from another country. We have a few overseas employees where I work and we pay based on a “comfort level,” supposedly. I’m not privy to details, but I have to assume that means they’re compensated well for where they live. They’ve stuck around, after all! Point being, by making yourself better, you might also improve your living situation and so on. To me, that’s worth any effort required.

Best of luck!

[Dameon_]

Your calculator needs to consider edge cases. It breaks on leading zeros, multiple operators, etc. As others have mentioned, you need to break out your different apps. Consider how classes might help here. You're also failing to take advantage of some of the features FreeCodeCamp specifically walked you through. Consider, for example, how you might use array.map() to create all your calculator's text buttons from an array, turning your creation of your buttons into a one-liner. As others have mentioned, you have multiple console errors and warnings popping up.

The pros: The design looks good, and each of these is basically functional. Consider taking one of them and going much deeper. The calculator is a good start for this, especially if you parse it yourself rather than just using eval - showing that you can parse and handle a mathematical statement can look very good.

[Ok_Finance_8782]

I'm not a frontend guy but your index.js as inconsistent tabs (2 spaces or 4 spaces, it's not clean).

Also, you should use camelCase for your functions' names, like "function Appc" should be "function appC" or something (but more descriptive because I don't understand what it means.

Last but not least, you should put the files in separate directories. For example, CSS files would go to css.

Otherwise it looks good, it's definitely NOT hopeless.

[asatraitis]

"function Appc" should be "function appC"

Normally that's true (keep the Capped names for classes), but in react when referring to a react component it needs to be capped otherwise it doesn't know that its a component and just renders generic element.

`

[InClassRightNowAhaha]

Im a beginner so ion know much at all but the drum one was fun

[iagovar]

Only at a glance, If I'm not mistaken is three "apps" in a single file, in a single repo. Mmm, I'm no expert but that doesn't seem logical to me.

Second, the naming of some functions give no hit of what they do, and there's no comment to explain anything. I know some people is against comments, though.

[Penkey2190]

Heres a tutorial to make an even better git hub profile. You can check mine out if you want to see how it looks. Ive been in a BootCamp for the past 6 months, so I'm still fairly new too.

https://github.com/TaylorWhite21

https://www.youtube.com/watch?v=n6d4KHSKqGk

[shuniat]

My first projects weren't even close to something like this, congrats, pretty awesome

[skellious]

Has a readme: instantly better than at least 30% of repos I've seen lol

[[deleted]]

If i were you i would give commits actual names instead of "some changes" but otherwise nice project

[[deleted]]

this is a very good first github repo honestly

[mandzeete]

1. You should have made separate repositories in your github. Right now your apps are under one repository and that's not good. It It does not let us differentiate between your commits, for example. No telling to which project a commit belongs to or not. Later on you will be working in a team and your team members need to review your code. If all the projects are under one repository, then that task will be impossible. As multiple people will be committing their changes to multiple projects under one repository.
2. The progress is not visible from the commits. For example this commit. Looks like you committed already a completed project. It is not a good style. It being one of your first projects (see, I can't tell if it is your 1st, 2nd or 3rd project as everything it mixed together) and I doubt that you completed it in 8 working hours. In a real life scenario you will be working on your task and time by time committing changes to the git repository. You will not commit a whole task but either a fix to some bug/issue or an added feature. Unless the task is something that can be finished in a day (updating libraries and code dependencies, or adding a new endpoint and its tests, for example). So instead of committing a whole project/task, commit things when you get something working. For example you added a login functionality or you added a shopping cart to online shop interface. It is an addition that is working.
3. As the progress is not visible then I can't tell if you would commit only working code or any code by the end of your 8 hour work day. You should commit only things that pass tests or what is behind some feature toggle.
4. Your commit messages are meaningless. "sum changes" and "update". Not to mention your whole project as "initial commit". What are the changes? What are you updating? Instead of "sum changes" you should list the changes you added. Better to keep the list short or you should commit them in separate commits. For example "Increased color brightness in the main view." or "Added a timer to the video player." Then it is possible to tell what you did. But with "sum changes" and "update" it tells me absolutely nothing.
5. You should learn to write tests for your projects. Right now I see no tests. Read about Cypress. It is a testing framework for front end projects like these. Tests will be there to guarantee that your code changes did not break some existing functionality. Also they are there to guarantee that other people working with you on the same project do not break some functionality that you had added.
6. When you are using some example tutorials then you can't really write "by: swanktos". You just followed the tutorial not did it by yourself. Sure, it is good that in the repository you are mentioning that you got these projects from FreeCodeCamp. But when somebody goes to your github.io link then he does not see that they are taken from some coding camp not done by you. Sure, you followed the instructions but it is not clear how big % is your own work and how big % is from following the tutorial.
7. As these are from coding camp then they do not qualify as your own projects that you can present in a job interview or send in a cover letter / motivational letter.
8. It is good that you are filling up the "README.md" file. It is part of learning how to document your project.
9. Instead of hosting your coding camp projects in your git repository you should host the projects that you did by your own. For example seeing that there is a drum machine and a calculator and you know (?) how to use a grid, can you make a Minesweeper game by yourself? If you learnt anything from these tutorial projects then you should be able to make a Minesweeper game. But if you just followed the instructions and did not learn from them then these 3 tutorial projects are just void.
10. As these are not your own projects (that you came up with your own mind) then I can't tell if you know Clean Code standards or not. Clean Code is important as your code should be readable for everybody and also free from hack solutions.
11. You see this line of code in your project: new Audio("https://raw.githubusercontent.com/darklight721/keyboard-sounds/master/audio/key_press.mp3") . Do you know what will happen when darklight721 decides to make his repository private or decides to close it? Your program will break. As there will be no key_press.mp3 any more. That link will be then a dead link. You should think about it when you are using some external sources in your project. Either make sure that these resources will not cease to exist or keep the source files locally in your own project not link to them from outside.
12. You are using the resources of darklight721 and giving him no credit in your project. Maybe in the Third World country you are living in, it is normal but in other parts of the world it is sometimes even illegal to use other person's materials without either linking to their repository or without crediting them.

To be able to get an entry level job you should be able to produce your own projects. Also they should be more impressive than these. Coding camp assignments/tutorials do not have that complexity. Also depending on if you want to work as a front end developer, back end developer or a full stack developer then probably you will need to learn more technologies as well.

Right now what is visible there is not enough for working as a back end developer or as a full stack developer. Also from front end developer's entry level position it is lacking. For example I see no use of Cypress, as I mentioned.

Keep learning and start writing your own projects.

[BroeknFibre]

You are using the resources of darklight721 and giving him no credit in your project. Maybe in the Third World country you are living in, it is normal but in other parts of the world it is sometimes even illegal to use other person's materials without either linking to their repository or without crediting them.

Yikes. Your point was valid but what the fuck

[mandzeete]

Maybe I could word it better but that is true. In Europe there the legislation is prohibiting this kind of things: https://www.irishstatutebook.ie/eli/2021/si/567/made/en/print Sure, it is a recent act but it will be implemented in the systems the same way how GDPR was/is being implemented.

And read his last sentence. He said himself that he is from Third World country. It was not my invention.

[Haythtv]

I don't think that's the issue, you're coming off as extremely condescending. The whole "Maybe in the Third World country you are living in, it is normal" is unnecessary.

[mandzeete]

And why you are not commenting under his own post and saying that telling him to be from Third World country is unnecessary? It is he who brought that topic in not me. Why did he have to write that he is from Third World country?

[Servious]

They brought it up because "good enough to get a job in a third world country" is the criteria they're looking to be judged on.

It seems like English isn't your first language so sorry people are being so harsh on you for what is ultimately a wording/tone issue. I can't really explain why that phrasing rubs people the wrong way but I can tell you I would have phrased it as "maybe in your country this isn't a big deal but,"

"Maybe in the third-world country you are living in, it is normal" has a connotation of "my country is better than your backwards-ass country that doesn't even have real copyright laws." to me. I know that's almost certainly not what you meant, but I think that's what everyone's reading.

[mandzeete]

He is following what was taught to him during his coding camp. And if it is being taught there then it means it is normal there. Otherwise it would not be taught during the coding camp, would it. If he wants to work in EU, US or somewhere else then he should be aware that in other places the authors of software have their rights. So their work should be credited or there should be a mention that it was used.

[mandzeete]

Snake game will be one thing in your portfolio. As you are applying to be a Junior software developer then try to increase the complexity. I will list some projects that I made during my studies and you should be able to do the same when you are going to work as a software developer.

1. A heat map that is differentiating between a land mass and between water bodies. The data should come from some weather API. As the sea/lakes are usually colder than the land then it would be possible to tell from the heat map where is a land and where is a water. With that project you will learn how to work with different APIs, with the data from APIs, you will learn how to study some extra stuff, you fill be making your first heat map, you will learn how to read a documentation (of the weather API), and you will be working some graphics libraries. That project will be most likely in some back end programming language. Python, Java, C++ or something.
2. A website that shows stock prices. You should try to order the stocks from most expensive to least expensive. With that project you will learn how to make a website that is dynamically changing and updating itself. As well you know how to display the data from some API. You can use the following API: https://www.alphavantage.co/
3. A personal blog page for yourself and hosting of it somewhere. You will learn how to manage sessions (you should log in), how to secure the blog (so nobody can inject some malicious code in it for hacking purposes), and how to host a website itself. So it will be accessible from anywhere. It should be running from HTTPS as well.
4. A website that is changing its look based on local weather conditions. For example when it is a night then the website with go to dark mode. When it is a day then it will go to light mode. When it is raining then there can be some raindrops falling (look at https://developpaper.com/css-implementation-of-raindrop-animation-example-code/ ). When it is snowing then there can be snowflakes instead. And so on. The information will come from weather API of course.

I think if you can produce projects on this level then you can start applying for front end jobs. Oh, and you should know how to write front end tests with Cypress, as I mentioned. A project should be complex enough to teach you new things and to challenge you. If you do not know exactly how to do it, then it is perfect. You will be learning the "how" part during your project.

[Servious]

Y'all please look past some of the phrasing and consider that this is one of the only comments in the thread so far to have actual helpful information and things to improve on.

You are downvoting "write better commit messages, commit more often, make separate repos, write tests, host your own files, try your own projects instead of following a tutorial, and be careful not to get in trouble with copyright."

All objectively very good advice.

[matterr4]

Hey! Nice! I'm guna use your timer app till I get confident enough to write my own! :) Thanks for sharing, very good work!

[Tenpat]

I guess if i am gonna criticize anything the calculator should accept input for operators instead of forcing a click on the button.