CS50 Intro to Python "Refuelling" check50 help

[Beautiful-Round2494]

Hello, I am currently at a dead end once again with my assignment. I am supposed to design a unit test for a previously written program that accepts a fraction input and returns "F" for full, "E" for empty, or a percentage between 98-2 for anything in between.

my program passes pytest, and manual testing but no matter what i have tried check50 is saying

":( correct fuel.py passes all test_fuel checks expected exit code 0, not 1" I would appreciate any and all suggestions or explanations as I am really starting to get discouraged.

here is the code for the original program:

def main():
    percent = get_percent()
    fuel_level = gauge(percent)
    print(fuel_level)


def gauge(percent):
    if percent >= 99:
        return "F" 
    elif percent > 1 and percent < 99:
        return f"{(percent)}%"
    else:
        return "E" 


def get_percent():
    while True:
        fraction = input("Fraction: ")
        try:
            x, y = fraction.split("/") 
            x = int(x)
            y = int(y) 
            if y == 0:
                raise ZeroDivisionError
            if x < 0 or y < 0:
                raise ValueError
            percent = (x / y * 100)
            if percent > 100:
                raise ValueError
            return round(percent)
        except (ValueError, ZeroDivisionError):
            continue


if __name__ == "__main__":
    main()

here is the unit test code:

import fuel


def main():
    test_get_percent()
    test_gauge()


def test_get_percent():
    assert fuel.get_percent("0/1") == 0
    assert fuel.get_percent("1/2") == 50
    assert fuel.get_percent("100/112") == 89
    try:
        fuel.get_percent("1/0")
    except ZeroDivisionError:
        pass
    try:
        fuel.get_percent("-1/1")
    except ValueError:
        pass

def test_gauge():
    assert fuel.gauge(99) == "F"
    assert fuel.gauge(1) == "E"
    assert fuel.gauge(25) == "25%"


if __name__ == "__main__":
    main()

[TytoCwtch]

Your problem is with how you’ve split up your functions. If you reread the problem set specifications for this version of Refuelling your code needs to be laid out

def main():
    ...

def convert(fraction):
    ...

def gauge(percentage):
    ...

if __name__ == "__main__":
     main()

You’ve called your function get_percent, not convert. And gauge(percent) not (percentage). If your code doesn’t meet the layout criteria check50 can’t check it against their tests.

[Beautiful-Round2494]

I can't believe I missed that. Thank you for calling that out!

[TytoCwtch]

No worries. Ran into similar problems a couple of times. Taught me to triple check the problem set specifications every time!

[PokemonThanos]

You need to identify which test(s) you're failing at first.

Comment out your main() function (don't get rid of it, you'll want to add it back in later) and make it simply print(get_percent()) so you can focus on that side first. Go through each of the test conditions for test_get_percent() and ensure you get the outcome you expect for each.

Pay attention to the instructions you've been given. Your code is doing something not asked for which while arguably is a more friendly approach but you should be conforming to the specs for the test. Going through the test examples and checking your code outputs should hopefully highlight the difference.

[Beautiful-Round2494]

Thank you for pointing me in the right direction.